From owner-cvs-src-old@FreeBSD.ORG Sat Jul 31 21:33:41 2010 Return-Path: Delivered-To: cvs-src-old@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C66401065670 for ; Sat, 31 Jul 2010 21:33:41 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id B3CAB8FC12 for ; Sat, 31 Jul 2010 21:33:41 +0000 (UTC) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.4/8.14.4) with ESMTP id o6VLXfwR045443 for ; Sat, 31 Jul 2010 21:33:41 GMT (envelope-from bz@repoman.freebsd.org) Received: (from svn2cvs@localhost) by repoman.freebsd.org (8.14.4/8.14.4/Submit) id o6VLXftc045442 for cvs-src-old@freebsd.org; Sat, 31 Jul 2010 21:33:41 GMT (envelope-from bz@repoman.freebsd.org) Message-Id: <201007312133.o6VLXftc045442@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: svn2cvs set sender to bz@repoman.freebsd.org using -f From: "Bjoern A. Zeeb" Date: Sat, 31 Jul 2010 21:33:18 +0000 (UTC) To: cvs-src-old@freebsd.org X-FreeBSD-CVS-Branch: HEAD Subject: cvs commit: src/sys/netinet if_ether.c src/sys/netinet6 nd6.c X-BeenThere: cvs-src-old@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: **OBSOLETE** CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Jul 2010 21:33:42 -0000 bz 2010-07-31 21:33:18 UTC FreeBSD src repository Modified files: sys/netinet if_ether.c sys/netinet6 nd6.c Log: SVN rev 210703 on 2010-07-31 21:33:18Z by bz Document the mandatory argument to the arptimer() and nd6_llinfo_timer() functions with a KASSERT(). Note: there is no need to return after panic. In the legacy IP case, only assign the arg after the check, in the IPv6 case, remove the extra checks for the table and interface as they have to be there unless we freed and forgot to cancel the timer. It doesn't matter anyway as we would panic on the NULL pointer deref immediately and the bug is elsewhere. This unifies the code of both address families to some extend. Reviewed by: rwatson MFC after: 6 days Revision Changes Path 1.220 +3 -5 src/sys/netinet/if_ether.c 1.135 +2 -7 src/sys/netinet6/nd6.c