From owner-freebsd-current@FreeBSD.ORG  Fri Oct 24 08:44:32 2008
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 582D01065672;
	Fri, 24 Oct 2008 08:44:32 +0000 (UTC) (envelope-from ianf@clue.co.za)
Received: from inbound01.jnb1.gp-online.net (inbound01.jnb1.gp-online.net
	[41.161.16.135])
	by mx1.freebsd.org (Postfix) with ESMTP id E8C3A8FC1F;
	Fri, 24 Oct 2008 08:44:31 +0000 (UTC) (envelope-from ianf@clue.co.za)
Received: from [41.241.57.12] (helo=clue.co.za)
	by inbound01.jnb1.gp-online.net with esmtpsa
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.63)
	(envelope-from <ianf@clue.co.za>)
	id 1KtHKA-0007Eg-T3; Fri, 24 Oct 2008 09:43:11 +0200
Received: from localhost ([127.0.0.1] helo=clue.co.za)
	by clue.co.za with esmtp (Exim 4.69 (FreeBSD))
	(envelope-from <ianf@clue.co.za>)
	id 1KtHK0-000ETW-1v; Fri, 24 Oct 2008 09:43:00 +0200
To: "Attilio Rao" <attilio@freebsd.org>
From: Ian FREISLICH <ianf@clue.co.za>
In-Reply-To: <3bbf2fe10810201303y54d1d611ibf94b1c60fcefaef@mail.gmail.com> 
References: <3bbf2fe10810201303y54d1d611ibf94b1c60fcefaef@mail.gmail.com>
	<E1KrpmD-0001S4-NF@clue.co.za> 
X-Attribution: BOFH
Date: Fri, 24 Oct 2008 09:43:00 +0200
Message-Id: <E1KtHK0-000ETW-1v@clue.co.za>
Cc: current@freebsd.org
Subject: Re: PATCH: vinvalbuf(9), fusefs-kmod 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 24 Oct 2008 08:44:32 -0000

"Attilio Rao" wrote:
> 2008/10/20, Ian Freislich <ianf@clue.co.za>:
> > Hi
> >
> >  It appears that vinvalbuf() has changed, but the manual page has
> >  not been updated.  Also, after this change, sysutils/fusefs-kmod
> >  doesn't compile.  These patches address both issues.
> 
> Sorry for the late action, but I updated manpage and bumped
> __FreeBSD_version so that ports maintainers can deal with that.

The man page is not correct:

SYNOPSIS
     #include <sys/param.h>
     #include <sys/vnode.h>

     int
     vinvalbuf(struct vnode *vp, int flags, struct ucred *cred, int slpflag,
         int slptimeo);

Yet, sys/vnode.h:
int     vinvalbuf(struct vnode *vp, int save, int slpflag, int slptimeo);

struct ucred *cred is not a parameter to this function like the
manual page suggests.

Ian

--
Ian Freislich