From owner-svn-ports-head@FreeBSD.ORG  Fri Nov  1 12:59:44 2013
Return-Path: <owner-svn-ports-head@FreeBSD.ORG>
Delivered-To: svn-ports-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 2A27ECF;
 Fri,  1 Nov 2013 12:59:44 +0000 (UTC) (envelope-from zi@FreeBSD.org)
Received: from exodus.zi0r.com (exodus.zi0r.com [71.245.171.203])
 (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id F192C2A25;
 Fri,  1 Nov 2013 12:59:43 +0000 (UTC)
Received: from exodus.zi0r.com (localhost [127.0.0.1])
 by exodus.zi0r.com (Postfix) with ESMTP id 9DF503AAAE;
 Fri,  1 Nov 2013 08:59:42 -0400 (EDT)
X-Virus-Scanned: amavisd-new at zi0r.com
Received: from exodus.zi0r.com ([127.0.0.1])
 by exodus.zi0r.com (exodus.zi0r.com [127.0.0.1]) (amavisd-new, port 10026)
 with LMTP id Ru-a9Pe-gVNJ; Fri,  1 Nov 2013 08:59:41 -0400 (EDT)
Received: from exodus.zi0r.com (syn.zi0r.com [71.245.171.202])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by exodus.zi0r.com (Postfix) with ESMTPSA id A953F3AAB0;
 Fri,  1 Nov 2013 08:59:41 -0400 (EDT)
Date: Fri, 1 Nov 2013 08:59:40 -0400
From: Ryan Steinmetz <zi@FreeBSD.org>
To: Boris Samorodov <bsam@passap.ru>
Subject: Re: svn commit: r332334 - in head/finance: . vanitygen
Message-ID: <20131101125940.GA8719@exodus.zi0r.com>
References: <201311010112.rA11Ch1h047872@svn.freebsd.org>
 <52738F84.8060906@passap.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
In-Reply-To: <52738F84.8060906@passap.ru>
User-Agent: Mutt/1.5.21 (2010-09-15)
Content-Transfer-Encoding: quoted-printable
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 01 Nov 2013 12:59:44 -0000


On (11/01/13 15:24), Boris Samorodov wrote:
>Hi Ryan, All,
>
>01.11.2013 05:12, Ryan Steinmetz =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>
>> Log:
>>   New port: finance/vanitygen:
>
>Thank you for working on new ports. It's always good to get a new one.
>However there are some notes inlined.
>
>> +MAINTAINER=3D	ports@FreeBSD.org
>
>I'm not sure that a new unmaintained port is welcomed.
>
>> +COMMENT=3D	A standalone vanity address generator for bitcoin

My bad on this, although, I had thought that portlint(1) would have caugh=
t
this.

>
>Articles should not be used at the beginning of a COMMENT.
>
>> +LIB_DEPENDS=3D	pcre:${PORTSDIR}/devel/pcre
>
>A new LIB_DEPENDS syntax is preferred.
>

Do you have the announcement?  After digging a bit, the only thing I was
able to find was the commit log.

>
>> +NO_STAGE=3D	yes
>
>I think that new ports are supposed to support STAGE.
>

I do not believe that Tinderbox supports STAGE, so I do not have a means
of testing it at the moment.


-r

>--=20
>WBR, Boris Samorodov (bsam)
>FreeBSD Committer, http://www.FreeBSD.org The Power To Serve

--=20
Ryan Steinmetz
PGP: EF36 D45A 5CA9 28B1 A550  18CD A43C D111 7AD7 FAF2