From owner-freebsd-bugs@freebsd.org Wed Mar 10 19:32:17 2021 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id B7295574BFC for ; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dwhzj4fDvz4ZDM for ; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 9EEE957506F; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9EB6E575384 for ; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dwhzj42Tbz4Z9s for ; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7DA3116CF3 for ; Wed, 10 Mar 2021 19:32:17 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 12AJWHV4039448 for ; Wed, 10 Mar 2021 19:32:17 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 12AJWHtW039447 for bugs@FreeBSD.org; Wed, 10 Mar 2021 19:32:17 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 251906] autofs: automounter always only adds to /var/db/mounttab but never clears it Date: Wed, 10 Mar 2021 19:32:17 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 12.2-RELEASE X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: d8zNeCFG@aon.at X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Mar 2021 19:32:17 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D251906 --- Comment #33 from Martin Birgmeier --- Hello Robert, Please excuse me - I currently do not have the time to test this (but I am still happily running your previous patches :-)). I have briefly looked at = the patch and assume it will be working. It appears like quite a sledgehammer method, first because it seems to nondiscriminatorely unmount everything, a= nd second because it still uses an exec (popen). I believe it would be better to build a small library for dealing with the interaction of NFS mounts and maintaining the mounttab (and probably also t= he mountdtab on the server) file and call that from both the automounter and rpc.umntall etc. That library should also take care of possibly simultaneous accesses to these files and properly lock/unlock them so that they cannot g= et corrupted while they are being updated/in use. Finally, this library should also take care of counting any possible mounts - one and the same NFS client might (and in my case, does) mount the same export twice in different place= s, and this must be properly handled in both mounttab and mountdtab. Best regards, Martin --=20 You are receiving this mail because: You are the assignee for the bug.=