From owner-cvs-src@FreeBSD.ORG Sun May 20 10:29:21 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id C64F516A421; Sun, 20 May 2007 10:29:21 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 7E91A13C44B; Sun, 20 May 2007 10:29:21 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A5FDC1.dip.t-dialin.net [84.165.253.193]) by redbull.bpaserver.net (Postfix) with ESMTP id 6A66F2E12E; Sun, 20 May 2007 12:29:17 +0200 (CEST) Received: from deskjail (deskjail.Leidinger.net [192.168.1.109]) by outgoing.leidinger.net (Postfix) with ESMTP id 6A4AC5B6169; Sun, 20 May 2007 12:29:01 +0200 (CEST) Date: Sun, 20 May 2007 12:29:15 +0200 From: Alexander Leidinger To: Dag-Erling Smorgrav Message-ID: <20070520122915.7d3a195d@deskjail> In-Reply-To: <200705192034.l4JKYTWN048806@repoman.freebsd.org> References: <200705192034.l4JKYTWN048806@repoman.freebsd.org> X-Mailer: Claws Mail 2.9.1 (GTK+ 2.10.12; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.864, required 8, autolearn=not spam, BAYES_00 -15.00, DK_POLICY_SIGNSOME 0.00, FORGED_RCVD_HELO 0.14) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No Cc: cvs-src@FreeBSD.org, kris@freebsd.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src Makefile.inc1 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 May 2007 10:29:21 -0000 Quoting Dag-Erling Smorgrav (Sat, 19 May 2007 20:34:29 +0000 (UTC)): > des 2007-05-19 20:34:29 UTC > > FreeBSD src repository > > Modified files: > . Makefile.inc1 > Log: > Revision 1.576 removed too much. I didn't notice because my /usr is on > ZFS, which doesn't support flags... My suggestion was to remove the chflags and add a echo in the failure case of rm, because in the current way the flags are removed even if the user tells to not remove a file at the interactive rm prompt and the user is not told about it. In my original version there was an echo that the flags are removed unconditionally. Dag-Erling doesn't like the echo of removing flags when there are no flags, and I don't like that there's no echo when removing flags. To try to come to a consensus I suggested the above. It seems we need a 3rd opinion (provide your bikeshed color wisely please, think 10 times before you reply). Bye, Alexander. -- It is wise to keep in mind that neither success nor failure is ever final. -- Roger Babson http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID = B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID = 72077137