From owner-freebsd-ports@FreeBSD.ORG Tue Nov 15 15:37:02 2005 Return-Path: X-Original-To: ports@FreeBSD.org Delivered-To: freebsd-ports@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B79AC16A41F; Tue, 15 Nov 2005 15:37:02 +0000 (GMT) (envelope-from nork@FreeBSD.org) Received: from sakura.ninth-nine.com (sakura.ninth-nine.com [219.127.74.120]) by mx1.FreeBSD.org (Postfix) with ESMTP id DF3D843D45; Tue, 15 Nov 2005 15:37:01 +0000 (GMT) (envelope-from nork@FreeBSD.org) Received: from nadesico.ninth-nine.com (nadesico.ninth-nine.com [219.127.74.122]) by sakura.ninth-nine.com (8.13.3/8.13.3/NinthNine) with ESMTP id jAFFb02X064718; Wed, 16 Nov 2005 00:37:00 +0900 (JST) (envelope-from nork@FreeBSD.org) Date: Wed, 16 Nov 2005 00:36:59 +0900 From: Norikatsu Shigemura To: Andrey Chernov Message-Id: <20051116003659.681c6944.nork@FreeBSD.org> In-Reply-To: <20051113125046.GA44237@nagual.pp.ru> References: <200511130038.jAD0cgLb043746@sakura.ninth-nine.com> <20051113120157.GA42256@nagual.pp.ru> <20051113212402.bf0fe702.nork@FreeBSD.org> <20051113125046.GA44237@nagual.pp.ru> X-Mailer: Sylpheed version 2.1.6 (GTK+ 2.8.6; i386-portbld-freebsd7.0) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (sakura.ninth-nine.com [219.127.74.121]); Wed, 16 Nov 2005 00:37:00 +0900 (JST) Cc: ports@FreeBSD.org, nork@FreeBSD.org Subject: Re: Integrated DEBUG related macros to WITH_DEBUG/WITHOUT_DEBUG X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 15 Nov 2005 15:37:02 -0000 On Sun, 13 Nov 2005 15:50:47 +0300 Andrey Chernov wrote: > > > *DEBUG knob has different meaning from port to port and often not just -g > > > adding, but turns on internal port debugging output/checks. > > > It means that it should be turned on/off separately on per port basis. > > > I.e. WITH__DEBUG. > > > WITH__* style options also allows to add them all into > > > /etc/make.conf without creating name conflicts between the ports. > > I don't think so. There are 127ports supported DEBUG related > > knobs. Only 127ports, and there are some ports which we > > request with DEBUG related knobs at the most. > > 'WITH_DEBUG' is well known and global knob. This is POLA > > important. If you want to turn on/off per port, you can > > set following description in /etc/make.conf. This is ungy, > > sure. But it's casual. > First of all, I don't see any sense to turn debug for all 127 ports at > once. For many years the only need I see - turn for one of them. So it Disscussed with: hrs I noticed my miss. Sorry I don't think that *ALL* DEBUG related knobs should be integrated. I consider that *AS POSSIBLE AS* DEBUG related knobs should be integated. >> ok? using *_DEBUG_* knobs. But I think that these should not >> be replaced to WITH_DEBUG. Semantics different. I know well that there are many ports which cannot be integrated. But I hope 'as possible as' and 'keep it simply'. > isn't "global knob" as you say. It is local per port knob and should not > affect other ports. Sure. WITH_DEBUG is well-known, I saied 'global'. But it is local per port. So I think that Stijn's idea is good.