From owner-svn-src-all@FreeBSD.ORG  Tue Jul 15 15:35:24 2014
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 8B5527BD;
 Tue, 15 Jul 2014 15:35:24 +0000 (UTC)
Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 5D29E229E;
 Tue, 15 Jul 2014 15:35:23 +0000 (UTC)
Received: from c-50-155-136-3.hsd1.co.comcast.net ([50.155.136.3]
 helo=ilsoft.org)
 by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256)
 (Exim 4.72) (envelope-from <ian@FreeBSD.org>)
 id 1X74lF-0004Xq-SF; Tue, 15 Jul 2014 15:35:22 +0000
Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240])
 by ilsoft.org (8.14.9/8.14.9) with ESMTP id s6FFZKft011308;
 Tue, 15 Jul 2014 09:35:20 -0600 (MDT) (envelope-from ian@FreeBSD.org)
X-Mail-Handler: Dyn Standard SMTP by Dyn
X-Originating-IP: 50.155.136.3
X-Report-Abuse-To: abuse@dyndns.com (see
 http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse
 reporting information)
X-MHO-User: U2FsdGVkX18o342t6ryahDcfSGW8qjWL
X-Authentication-Warning: paranoia.hippie.lan: Host revolution.hippie.lan
 [172.22.42.240] claimed to be [172.22.42.240]
Subject: Re: svn commit: r268660 - head/sys/amd64/amd64
From: Ian Lepore <ian@FreeBSD.org>
To: Konstantin Belousov <kostikbel@gmail.com>
In-Reply-To: <20140715153011.GR93733@kib.kiev.ua>
References: <201407150930.s6F9Uhgi052394@svn.freebsd.org>
 <1405432340.1312.26.camel@revolution.hippie.lan>
 <20140715153011.GR93733@kib.kiev.ua>
Content-Type: text/plain; charset="us-ascii"
Date: Tue, 15 Jul 2014 09:35:20 -0600
Message-ID: <1405438520.1312.32.camel@revolution.hippie.lan>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jul 2014 15:35:24 -0000

On Tue, 2014-07-15 at 18:30 +0300, Konstantin Belousov wrote:
> On Tue, Jul 15, 2014 at 07:52:20AM -0600, Ian Lepore wrote:
> > >  		bcopy(a_cp, b_cp, cnt);
> > > +		if (__predict_false(pinned)) {
> > > +			sched_unpin();
> > > +			mtx_unlock(&cpage_lock);
> > > +			pinned = FALSE;
> > 
> > Should this pinned = FALSE be done under the cpage_lock to avoid a race?
> 
> What race ? Could you describe it in more details ?
> Note that pinned is local variable.

Ahh, so it is.  I just noticed that it was set under the lock and
cleared outside of the lock, and didn't look at the scope of the
variable.  Sorry for the noise.

-- Ian