From nobody Tue Jul 5 21:43:14 2022 X-Original-To: freebsd-bluetooth@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 8FB791D14A27 for ; Tue, 5 Jul 2022 21:43:24 +0000 (UTC) (envelope-from kempe@lysator.liu.se) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lcx4W64twz4RQV for ; Tue, 5 Jul 2022 21:43:23 +0000 (UTC) (envelope-from kempe@lysator.liu.se) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 6ADA2D843; Tue, 5 Jul 2022 23:43:15 +0200 (CEST) Received: from shipon.lysator.liu.se (unknown [IPv6:2001:6b0:17:f0a0::83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 67B7FD646; Tue, 5 Jul 2022 23:43:15 +0200 (CEST) Date: Tue, 5 Jul 2022 23:43:14 +0200 From: Andreas Kempe To: Marc Veldman Cc: freebsd-bluetooth@freebsd.org Subject: Re: [PATCH]: securesimplepairing@shipon.lysator.liu.se; Message-ID: References: <96CF7D6F-0E82-4409-8DD1-D9B089602805@bumblingdork.com> List-Id: Using Bluetooth in FreeBSD environments List-Archive: https://lists.freebsd.org/archives/freebsd-bluetooth List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-bluetooth@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <96CF7D6F-0E82-4409-8DD1-D9B089602805@bumblingdork.com> X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Queue-Id: 4Lcx4W64twz4RQV X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=pass (policy=none) header.from=lysator.liu.se; spf=pass (mx1.freebsd.org: domain of kempe@lysator.liu.se designates 130.236.254.3 as permitted sender) smtp.mailfrom=kempe@lysator.liu.se X-Spamd-Result: default: False [-4.00 / 15.00]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+a:mail.lysator.liu.se]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_THREE(0.00)[3]; TO_MATCH_ENVRCPT_SOME(0.00)[]; MID_RHS_MATCH_FROMTLD(0.00)[]; RCVD_IN_DNSWL_MED(-0.20)[130.236.254.3:from]; RCPT_COUNT_TWO(0.00)[2]; DMARC_POLICY_ALLOW(-0.50)[lysator.liu.se,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; MLMMJ_DEST(0.00)[freebsd-bluetooth]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:2843, ipnet:130.236.0.0/16, country:SE]; RCVD_TLS_LAST(0.00)[] X-ThisMailContainsUnwantedMimeParts: N On Tue, Jul 05, 2022 at 07:29:14PM +0200, Marc Veldman wrote: > Hello Andreas > Hello Marc, > > On 5 Jul 2022, at 17:35, Andreas Kempe wrote: > > > > Hello everyone, > > > > For my bluetooth daemon project, called blued, I wrote a patch that > > adds some HCI commands to netgraph to allow for secure simple pairing > > to work. I would like to upstream my patch so my software can be used > > without the end-user having to patch the kernel. I've attached my > > patch for review. > > > > I’ve compiled an booted a recent -CURRENT kernel with the patch, > and everything seems OK. The code looks OK as well. Thank you for testing the patch! > Did you create a PR? I did a superficial scan but couldn’t find it. > I've not created a PR at this time. I'll have a look at creating a report on the bugzilla tomorrow and I will notify the thread when it's done. Cordially, Andreas Kempe