From owner-svn-ports-head@freebsd.org  Sun Jan 29 18:50:06 2017
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id D886BCC7FE8;
 Sun, 29 Jan 2017 18:50:06 +0000 (UTC)
 (envelope-from freebsd@toco-domains.de)
Received: from toco-domains.de (mail.toco-domains.de
 [IPv6:2a01:4f8:150:50a5::6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id A315B15EF;
 Sun, 29 Jan 2017 18:50:06 +0000 (UTC)
 (envelope-from freebsd@toco-domains.de)
Received: from [192.168.1.22] (x4d0a1d5c.dyn.telefonica.de [77.10.29.92])
 by toco-domains.de (Postfix) with ESMTPA id 514B91AAF056;
 Sun, 29 Jan 2017 19:50:03 +0100 (CET)
Subject: Re: svn commit: r432561 - head/lang/php71
To: John Marino <marino@FreeBSD.org>, ports-committers@freebsd.org,
 svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
References: <201701271852.v0RIqOvW033749@repo.freebsd.org>
Cc: Mathieu Arnold <mat@FreeBSD.org>
From: Torsten Zuehlsdorff <freebsd@toco-domains.de>
Message-ID: <6aebcd6a-0439-f23a-be9d-e06f46d3511b@toco-domains.de>
Date: Sun, 29 Jan 2017 19:50:02 +0100
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <201701271852.v0RIqOvW033749@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 29 Jan 2017 18:50:07 -0000



On 27.01.2017 19:52, John Marino wrote:
> Author: marino
> Date: Fri Jan 27 18:52:24 2017
> New Revision: 432561
> URL: https://svnweb.freebsd.org/changeset/ports/432561
>
> Log:
>   lang/php71: Bring DTRACE exclude for DF from lang/php70
>
>   Maybe this would have been caught with SVN copy?  Oh well.
>
>   Approved by:	just-fix-it

Its funny how "just-fix-it" often translate in "just-broke-it" - see 
r432567.

But beside that back to being serious: why did nobody suggest a fix? If 
repo-copy is this needed, we can do it right now?
svn rm lang/php71 && svn cp -r432321 lang/php70 lang/php71 && some files 
copied would be all.
I took mat into CC because i want to know if something speaks against it 
or if just nobody thought about it.

Also fun note: with an svn copy the DTRACE option wouldn't be included 
too. I finished the patch 2 month ago, long before DTRACE was 
introduced. So it wouldn't be there.
I just noted in this 2 month how hard it is to find somebody for review 
and second how hard it is to get such a patch reviewed. First the 
review.freebsd.org didn't work for me because it contains a bug with 
umlaut for years. And second a repocopy could not be displayed.
So there is a wide field for human errors we should address. I have at 
least some ideas about that.

Greetings,
Torsten