From owner-freebsd-stable@FreeBSD.ORG Fri Dec 21 13:17:14 2007 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 78C0E16A417 for ; Fri, 21 Dec 2007 13:17:14 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from falcon.cybervisiontech.com (falcon.cybervisiontech.com [217.20.163.9]) by mx1.freebsd.org (Postfix) with ESMTP id DFDC013C448 for ; Fri, 21 Dec 2007 13:17:13 +0000 (UTC) (envelope-from avg@icyb.net.ua) Received: from localhost (localhost [127.0.0.1]) by falcon.cybervisiontech.com (Postfix) with ESMTP id A14BD74400C; Fri, 21 Dec 2007 15:17:11 +0200 (EET) X-Virus-Scanned: Debian amavisd-new at falcon.cybervisiontech.com Received: from falcon.cybervisiontech.com ([127.0.0.1]) by localhost (falcon.cybervisiontech.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OCewYfnfzwGq; Fri, 21 Dec 2007 15:17:11 +0200 (EET) Received: from [10.2.1.87] (gateway.cybervisiontech.com.ua [88.81.251.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by falcon.cybervisiontech.com (Postfix) with ESMTP id 2238074400A; Fri, 21 Dec 2007 15:17:11 +0200 (EET) Message-ID: <476BBCD6.2070804@icyb.net.ua> Date: Fri, 21 Dec 2007 15:17:10 +0200 From: Andriy Gapon User-Agent: Thunderbird 2.0.0.9 (X11/20071116) MIME-Version: 1.0 To: freebsd-stable@freebsd.org, freebsd-scsi@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: Jeremy Messenger Subject: reduce verboseness for certain scsi error X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Dec 2007 13:17:14 -0000 I would like to request your opinion on the following proposal: 1. introduce new scsi_sense_action_qualifier value SSQ_PRINT_SENSE_VERBOSE, which would mean that detailed command and response information is to be printed only if bootverbose==1; 2. introduce new define SS_FATAL_NORMAL with value of (SS_FAIL|SSQ_PRINT_SENSE_VERBOSE), which would mean a fatal SCSI error that can happen in "normal conditions", i.e. in the most cases the error doesn't imply a problem with a peripheral device, media, bus, controller, etc; 3. use the above SS_FATAL_NORMAL for at least the following conditions: (a)"Medium not present" (a)"Illegal mode for this track" (a) seems to be a common place for empty CD-ROM drive, empty card-reader, multi-slot card-readers with empty slots etc; (b) seems to be produced when certain pieces of software try to analyze media (distinguish data CD from audio CD, I think); 4. modify camperiphscsisenseerror() to honor the new flag defined above; Rationale for this request is that kernel messages easily get spammed with the error reports which do not really mean error conditions. Some amount of such noise comes from the kernel-land actions, lots more can come from user-land programs unwittingly trying to do certain things on the devices with no media or wrong media (example: hald). P.S. couple of links describing end-user experience (mine included): http://lists.freebsd.org/pipermail/freebsd-gnome/2007-January/016544.html http://forums.pcbsd.org/viewtopic.php?f=7&t=7044 http://lists.freebsd.org/pipermail/freebsd-gnome/2007-December/018816.html P.P.S. I am not saying that the issue is a kernel problem and must be resolved in kernel. It would be nice to see hald becoming a little bit smarter too. But I think that the above change would be nice and proper regardless of hald. -- Andriy Gapon