Date: Tue, 30 Jul 2013 08:30:17 -0700 From: David Wolfskill <david@catwhisker.org> Cc: current@freebsd.org, i386@freebsd.org Subject: Re: [head tinderbox] failure on i386/i386 Message-ID: <20130730153017.GQ1591@albert.catwhisker.org> In-Reply-To: <201307300758.r6U7whhB040393@freebsd-current.sentex.ca> References: <201307300758.r6U7whhB040393@freebsd-current.sentex.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
--yPSgZSQ6mfPWgZ9n
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Jul 30, 2013 at 07:58:43AM +0000, FreeBSD Tinderbox wrote:
> TB --- 2013-07-30 04:40:20 - tinderbox 2.10 running on freebsd-current.se=
ntex.ca
> TB --- 2013-07-30 04:40:20 - FreeBSD freebsd-current.sentex.ca 8.3-PREREL=
EASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebs=
d-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64
> TB --- 2013-07-30 04:40:20 - starting HEAD tinderbox run for i386/i386
> TB --- 2013-07-30 04:40:20 - cleaning the object tree
> TB --- 2013-07-30 04:45:33 - /usr/local/bin/svn stat /src
> TB --- 2013-07-30 04:45:36 - At svn revision 253790
> ...
> cc -O2 -pipe -std=3Dgnu99 -Qunused-arguments -fstack-protector -Wsystem=
-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign=
-Wno-empty-body -Wno-string-plus-int -Wno-tautological-compare -Wno-unused=
-value -Wno-parentheses-equality -Wno-unused-function -Wno-conversion -Wno-=
switch -Wno-switch-enum -Wno-knr-promoted-parameter -o watch watch.o -lter=
mcap
> gzip -cn /src/usr.sbin/watch/watch.8 > watch.8.gz
> =3D=3D=3D> usr.sbin/watchdogd (all)
> cc -O2 -pipe -std=3Dgnu99 -Qunused-arguments -fstack-protector -Wsystem=
-headers -Werror -Wall -Wno-format-y2k -W -Wno-unused-parameter -Wstrict-pr=
ototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -Wcast-qual -Ww=
rite-strings -Wswitch -Wshadow -Wunused-parameter -Wcast-align -Wchar-subsc=
ripts -Winline -Wnested-externs -Wredundant-decls -Wold-style-definition -W=
missing-variable-declarations -Wno-pointer-sign -Wno-empty-body -Wno-string=
-plus-int -c /src/usr.sbin/watchdogd/watchdogd.c
> /src/usr.sbin/watchdogd/watchdogd.c:777:18: error: comparison of integers=
of different signs: 'u_int' (aka 'unsigned int') and 'time_t' (aka 'int') =
[-Werror,-Wsign-compare]
> if (pretimeout >=3D ts.tv_sec) {
> ~~~~~~~~~~ ^ ~~~~~~~~~
> 1 error generated.
> *** Error code 1
>=20
> Stop.
> bmake: stopped in /src/usr.sbin/watchdogd
> *** Error code 1
> ....
OK that's been bugging me enough that I looked for a way to address it
this morning as I was on the train heading in to work.
The following appears to fix it for me:
Index: usr.sbin/watchdogd/watchdogd.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- usr.sbin/watchdogd/watchdogd.c (revision 253798)
+++ usr.sbin/watchdogd/watchdogd.c (working copy)
@@ -774,7 +774,7 @@
struct timespec ts;
=20
pow2ns_to_ts(timeout, &ts);
- if (pretimeout >=3D ts.tv_sec) {
+ if (pretimeout >=3D (intmax_t)ts.tv_sec) {
errx(EX_USAGE,
"pretimeout (%d) >=3D timeout (%d -> %ld)\n"
"see manual section TIMEOUT RESOLUTION",
This was running:
FreeBSD 10.0-CURRENT #967 r253701M/253704:1000040: Sat Jul 27 05:40:04 PDT=
2013 root@g1-227.catwhisker.org:/common/S4/obj/usr/src/sys/CANARY i386
and which built:
FreeBSD 10.0-CURRENT #968 r253795M/253798:1000040: Tue Jul 30 07:59:28 PDT=
2013 root@g1-227.catwhisker.org:/common/S4/obj/usr/src/sys/CANARY i386
Peace,
david
--=20
David H. Wolfskill david@catwhisker.org
Taliban: Evil men with guns afraid of truth from a 14-year old girl.
See http://www.catwhisker.org/~david/publickey.gpg for my public key.
--yPSgZSQ6mfPWgZ9n
Content-Type: application/pgp-signature
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.20 (FreeBSD)
iEYEARECAAYFAlH33AgACgkQmprOCmdXAD1QHQCeINJB5tc9ZtVL1k6jzHIVIOHZ
VlEAnjckAEfeIrxC7iAc4CiBjXafNMjx
=+g+v
-----END PGP SIGNATURE-----
--yPSgZSQ6mfPWgZ9n--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130730153017.GQ1591>