From owner-freebsd-fs@FreeBSD.ORG Thu Oct 7 18:25:08 2010 Return-Path: Delivered-To: freebsd-fs@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7E413106564A for ; Thu, 7 Oct 2010 18:25:08 +0000 (UTC) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id E1A398FC08 for ; Thu, 7 Oct 2010 18:25:07 +0000 (UTC) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 7BA5E45C9C; Thu, 7 Oct 2010 20:25:06 +0200 (CEST) Received: from localhost (chello089073192049.chello.pl [89.73.192.49]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 8AFC245685; Thu, 7 Oct 2010 20:25:00 +0200 (CEST) Date: Thu, 7 Oct 2010 20:24:36 +0200 From: Pawel Jakub Dawidek To: Mikolaj Golub Message-ID: <20101007182436.GB1733@garage.freebsd.pl> References: <86hbh44wgl.fsf@kopusha.home.net> <86aamw4l42.fsf@kopusha.home.net> <20101004213647.GK7322@garage.freebsd.pl> <86tyl1m85y.fsf@zhuzha.ua1> <20101005074736.GM7322@garage.freebsd.pl> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="gatW/ieO32f1wygP" Content-Disposition: inline In-Reply-To: <20101005074736.GM7322@garage.freebsd.pl> User-Agent: Mutt/1.4.2.3i X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 9.0-CURRENT amd64 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-2.6 required=4.5 tests=BAYES_00 autolearn=ham version=3.0.4 Cc: freebsd-fs@freebsd.org Subject: Re: hastd: assertion (res->hr_event != NULL) fails in secondary on split-brain X-BeenThere: freebsd-fs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Filesystems List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Oct 2010 18:25:08 -0000 --gatW/ieO32f1wygP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Oct 05, 2010 at 09:47:36AM +0200, Pawel Jakub Dawidek wrote: > On Tue, Oct 05, 2010 at 10:05:13AM +0300, Mikolaj Golub wrote: > >=20 > > On Mon, 4 Oct 2010 23:36:47 +0200 Pawel Jakub Dawidek wrote: > >=20 > > PJD> I see three problems:) > >=20 > > PJD> 1. In child_kill() you interpret status value always, even if it = is > > PJD> invalid due to earlier errors. > > PJD> 2. While copying the code you changed style. Don't you like style= (9)?:) > >=20 > > Me like :-). But it looks like my emacs don't. Need to teach it somehow= ... > >=20 > > PJD> 3. The patch doesn't fix the root cause of the problem. > >=20 > > Thank you for your comments. >=20 > The hang you reported is still not fixed, but I'm working on it. Could you verify if the primary/secondary loop doesn't cause hangs anymore with most recent hast? --=20 Pawel Jakub Dawidek http://www.wheelsystems.com pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --gatW/ieO32f1wygP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAkyuEGQACgkQForvXbEpPzQa1ACgkY4v73X1hvxGw3xjtgpJReNO /MEAoJw6YR8bZgJvUT5KfFwpqbWGnWHx =0n0/ -----END PGP SIGNATURE----- --gatW/ieO32f1wygP--