From owner-p4-projects@FreeBSD.ORG Mon Jul 11 11:25:28 2005 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 41B3516A421; Mon, 11 Jul 2005 11:25:28 +0000 (GMT) X-Original-To: perforce@FreeBSD.org Delivered-To: perforce@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id F2DC516A41C; Mon, 11 Jul 2005 11:25:27 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from ameno.mahoroba.org (gw4.mahoroba.org [218.45.22.175]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1DE0343D46; Mon, 11 Jul 2005 11:25:26 +0000 (GMT) (envelope-from ume@mahoroba.org) Received: from localhost (IDENT:QmyQvbsgZPv2B2s4ITzpLTqNVLLB5H3gSIUe2YLwyIV6yKHctECmkLyBShAxVphQ@localhost [IPv6:::1]) (user=ume mech=CRAM-MD5 bits=0) by ameno.mahoroba.org (8.13.3/8.13.3) with ESMTP/inet6 id j6BBPM1K002130 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jul 2005 20:25:22 +0900 (JST) (envelope-from ume@mahoroba.org) Date: Mon, 11 Jul 2005 20:25:21 +0900 Message-ID: From: Hajimu UMEMOTO To: soc-bushman In-Reply-To: <200507111108.j6BB8ExJ013721@repoman.freebsd.org> References: <200507111108.j6BB8ExJ013721@repoman.freebsd.org> User-Agent: xcite1.38> Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.7 (=?ISO-8859-4?Q?Sanj=F2?=) APEL/10.6 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) X-Operating-System: FreeBSD 5.4-STABLE X-PGP-Key: http://www.imasy.or.jp/~ume/publickey.asc X-PGP-Fingerprint: 1F00 0B9E 2164 70FC 6DC5 BF5F 04E9 F086 BF90 71FE Organization: Internet Mutual Aid Society, YOKOHAMA MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0 (ameno.mahoroba.org [IPv6:::1]); Mon, 11 Jul 2005 20:25:22 +0900 (JST) X-Virus-Scanned: by amavisd-new X-Virus-Status: Clean X-Spam-Status: No, score=-5.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham version=3.0.4 X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on ameno.mahoroba.org Cc: Perforce Change Reviews Subject: Re: PERFORCE change 79976 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2005 11:25:29 -0000 Hi, >>>>> On Mon, 11 Jul 2005 11:08:14 GMT >>>>> soc-bushman said: soc-bushman> ==== //depot/projects/soc2005/nsswitch_cached/src/lib/libc/net/netdb_private.h#4 (text+ko) ==== soc-bushman> @@ -134,11 +134,11 @@ soc-bushman> int getprotobyname_r(const char *, struct protoent *, struct protoent_data *); soc-bushman> int getprotobynumber_r(int, struct protoent *, struct protoent_data *); soc-bushman> int getprotoent_r(struct protoent *, struct protoent_data *); soc-bushman> -int getservbyname_r(const char *, const char *, struct servent *, soc-bushman> - char *, size_t, struct servent **); soc-bushman> -int getservbyport_r(int, const char *, struct servent *, soc-bushman> - char *, size_t, struct servent **); soc-bushman> -int getservent_r(struct servent *, char *, size_t, struct servent **); soc-bushman> +struct servent *getservbyname_r(const char *, const char *, struct servent *, soc-bushman> + char *, size_t); soc-bushman> +struct servent *getservbyport_r(int, const char *, struct servent *, soc-bushman> + char *, size_t); soc-bushman> +struct servent *getservent_r(struct servent *, char *, size_t); soc-bushman> void sethostent_r(int, struct hostent_data *); soc-bushman> void setnetent_r(int, struct netent_data *); soc-bushman> void setprotoent_r(int, struct protoent_data *); Why did you need to change the return value of *_r() functions from int to struct servent *. Though *_r() are not exposed yet, these should be int for consistensy with other platforms. So, please don't change them. Sincerely, -- Hajimu UMEMOTO @ Internet Mutual Aid Society Yokohama, Japan ume@mahoroba.org ume@{,jp.}FreeBSD.org http://www.imasy.org/~ume/