From owner-freebsd-current@FreeBSD.ORG  Sun Apr  6 16:44:45 2014
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id D4FC0648;
 Sun,  6 Apr 2014 16:44:45 +0000 (UTC)
Received: from mail.ignoranthack.me (ujvl.x.rootbsd.net [199.102.79.106])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id AFC9AF33;
 Sun,  6 Apr 2014 16:44:45 +0000 (UTC)
Received: from [192.168.1.102] (c-24-6-177-88.hsd1.ca.comcast.net
 [24.6.177.88])
 (using SSLv3 with cipher DHE-RSA-AES128-SHA (128/128 bits))
 (No client certificate requested)
 (Authenticated sender: sbruno@ignoranthack.me)
 by mail.ignoranthack.me (Postfix) with ESMTPSA id 214371929C8;
 Sun,  6 Apr 2014 16:44:44 +0000 (UTC)
Subject: Re: static linking, libc multiple definitions
From: Sean Bruno <sbruno@ignoranthack.me>
To: David Chisnall <theraven@FreeBSD.org>
In-Reply-To: <0650344F-FF86-4675-8724-0018AA00740B@FreeBSD.org>
References: <1396799725.37365.4.camel@powernoodle.corp.yahoo.com>
 <0650344F-FF86-4675-8724-0018AA00740B@FreeBSD.org>
Content-Type: multipart/signed; micalg="pgp-sha1";
 protocol="application/pgp-signature"; boundary="=-No8rLBSdjpcJcVDvxJFB"
Date: Sun, 06 Apr 2014 09:44:43 -0700
Message-ID: <1396802683.1472.0.camel@powernoodle.corp.yahoo.com>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Cc: "freebsd-current@freebsd.org" <freebsd-current@freebsd.org>
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
Reply-To: sbruno@freebsd.org
List-Id: Discussions about the use of FreeBSD-current
 <freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-current>, 
 <mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current/>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
 <mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 06 Apr 2014 16:44:45 -0000


--=-No8rLBSdjpcJcVDvxJFB
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sun, 2014-04-06 at 17:12 +0100, David Chisnall wrote:
> It looks like these two are defined in rpc_com.h, so they are declared an=
d defined in multiple compilation units.  That's not actually wrong (they'l=
l have common linkage and be merged), but it's discouraged because it can m=
ask other errors.  Can you see if this patch fixes it for you?
>=20
> David
>=20
>=20
> Index: rpc/rpc_com.h
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- rpc/rpc_com.h       (revision 264068)
> +++ rpc/rpc_com.h       (working copy)
> @@ -86,8 +86,8 @@
>  bool_t __xdrrec_getrec(XDR *, enum xprt_stat *, bool_t);
>  void __xprt_unregister_unlocked(SVCXPRT *);
> =20
> -SVCXPRT **__svc_xports;
> -int __svc_maxrec;
> +extern SVCXPRT **__svc_xports;
> +extern int __svc_maxrec;
> =20
>  __END_DECLS
> =20
> Index: rpc/svc.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- rpc/svc.c   (revision 264068)
> +++ rpc/svc.c   (working copy)
> @@ -84,6 +84,9 @@
>         void                (*sc_dispatch)(struct svc_req *, SVCXPRT *);
>  } *svc_head;
> =20
> +SVCXPRT **__svc_xports;
> +int __svc_maxrec;
> +
>  static struct svc_callout *svc_find(rpcprog_t, rpcvers_t,
>      struct svc_callout **, char *);
>  static void __xprt_do_unregister (SVCXPRT *xprt, bool_t dolock);
>=20
>=20


Yep, that make it much quieter now.  :-)  Thank you.

sean

--=-No8rLBSdjpcJcVDvxJFB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAABAgAGBQJTQYR3AAoJEBkJRdwI6BaHk5MH/AqC3rRsjQ4+0m0JySWqKIXz
EMWersVyWLzB7aN6542A73iWCratOLmSuwUAmoFXNR/AwrZPbyJVuhXlcX6thsVn
p4J/3W3vvbav7dBswU/yIUlWdtP/k7OSX5Xnampy9Uu5hlvff7e7poFkQwtCZHVB
7a5r9lbmb8DDuGwI0TgMuLhoR6gbtVri4geiuXujMDExoIOsoZlRtR8ufBNncn2M
QZUNUDhRveOQKBvK7STWNhcTPi8rcS7xYHiiFelqrCQQm6pouxULkvcOwDcBydEi
8EK9ML8ZxFu8zwaGoqKMU5Jwjq7LXSCq5F583oI4iDdWuoY23mHw3p4lhBatMz8=
=NwtB
-----END PGP SIGNATURE-----

--=-No8rLBSdjpcJcVDvxJFB--