From owner-svn-src-head@FreeBSD.ORG  Mon Nov 21 18:39:35 2011
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 25EDA1065742;
	Mon, 21 Nov 2011 18:39:35 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.freebsd.org (Postfix) with ESMTP id AEBF68FC15;
	Mon, 21 Nov 2011 18:39:34 +0000 (UTC)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.14.4/8.14.4/ALCHEMY.FRANKEN.DE) with ESMTP id
	pALIdX0F059412; Mon, 21 Nov 2011 19:39:33 +0100 (CET)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.14.4/8.14.4/Submit) id pALIdXZK059411;
	Mon, 21 Nov 2011 19:39:33 +0100 (CET) (envelope-from marius)
Date: Mon, 21 Nov 2011 19:39:33 +0100
From: Marius Strobl <marius@alchemy.franken.de>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20111121183933.GK56603@alchemy.franken.de>
References: <201111191011.pAJABp0N034812@svn.freebsd.org>
	<201111211116.47529.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201111211116.47529.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org, Hans Petter Selasky <hselasky@freebsd.org>
Subject: Re: svn commit: r227701 - in head/sys: arm/xscale/ixp425 dev/ahci
	dev/ata dev/gpio dev/mvs dev/ppbus dev/ppc dev/siba dev/siis
	dev/usb kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Nov 2011 18:39:35 -0000

On Mon, Nov 21, 2011 at 11:16:47AM -0500, John Baldwin wrote:
> On Saturday, November 19, 2011 5:11:51 am Hans Petter Selasky wrote:
> > Author: hselasky
> > Date: Sat Nov 19 10:11:50 2011
> > New Revision: 227701
> > URL: http://svn.freebsd.org/changeset/base/227701
> > 
> > Log:
> >   Move the device_delete_all_children() function from usb_util.c
> >   to kern/subr_bus.c. Simplify this function so that it no longer
> >   depends on malloc() to execute. Identify a few other places where
> >   it makes sense to use device_delete_all_children().
> >   
> >   MFC after:	1 week
> 
> Sorry I didn't review this earlier when you sent it to me.  In general I
> think this is a good idea, and reducing the duplicated code is great.

Could we rename it to just device_delete_children(9)? Using both "all" and
the plural seems redundant and doesn't match device_get_children(9) which
also operates on all children.

Marius