From owner-svn-src-head@FreeBSD.ORG  Fri Sep 18 14:42:11 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9A0391065693;
	Fri, 18 Sep 2009 14:42:11 +0000 (UTC)
	(envelope-from brde@optusnet.com.au)
Received: from mail07.syd.optusnet.com.au (mail07.syd.optusnet.com.au
	[211.29.132.188])
	by mx1.freebsd.org (Postfix) with ESMTP id 335F98FC12;
	Fri, 18 Sep 2009 14:42:10 +0000 (UTC)
Received: from c122-107-125-150.carlnfd1.nsw.optusnet.com.au
	(c122-107-125-150.carlnfd1.nsw.optusnet.com.au [122.107.125.150])
	by mail07.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id
	n8IEg8FB003742
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Sat, 19 Sep 2009 00:42:09 +1000
Date: Sat, 19 Sep 2009 00:42:08 +1000 (EST)
From: Bruce Evans <brde@optusnet.com.au>
X-X-Sender: bde@delplex.bde.org
To: Roman Divacky <rdivacky@freebsd.org>
In-Reply-To: <200909171748.n8HHmDAJ065382@svn.freebsd.org>
Message-ID: <20090919002807.R9375@delplex.bde.org>
References: <200909171748.n8HHmDAJ065382@svn.freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r197294 - in head/sys: kern sys
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 18 Sep 2009 14:42:11 -0000

On Thu, 17 Sep 2009, Roman Divacky wrote:

> Log:
>  Fix the style of the previous commit.

This fixes half of the new style bugs on the changed lines only.

> Modified: head/sys/kern/kern_event.c
> ==============================================================================
> --- head/sys/kern/kern_event.c	Thu Sep 17 17:41:28 2009	(r197293)
> +++ head/sys/kern/kern_event.c	Thu Sep 17 17:48:13 2009	(r197294)
> @@ -145,7 +145,8 @@ static int	filt_timer(struct knote *kn,
> static int	filt_userattach(struct knote *kn);
> static void	filt_userdetach(struct knote *kn);
> static int	filt_user(struct knote *kn, long hint);
> -static void	filt_usertouch(struct knote *kn, struct kevent *kev, unsigned long type);
> +static void	filt_usertouch(struct knote *kn, struct kevent *kev,
> +		    unsigned long type);

"unsigned foo" is spelled "u_foo" in KNF.  kern/kern_event.c followed this rule
in all cases until recently.

Following this rule often (but not here) keeps line lengths below 80
characters.

> Modified: head/sys/sys/event.h
> ==============================================================================
> --- head/sys/sys/event.h	Thu Sep 17 17:41:28 2009	(r197293)
> +++ head/sys/sys/event.h	Thu Sep 17 17:48:13 2009	(r197294)
> @@ -191,7 +191,8 @@ struct filterops {
> 	int	(*f_attach)(struct knote *kn);
> 	void	(*f_detach)(struct knote *kn);
> 	int	(*f_event)(struct knote *kn, long hint);
> -	void	(*f_touch)(struct knote *kn, struct kevent *kev, unsigned long type);
> +	void	(*f_touch)(struct knote *kn, struct kevent *kev,
> +		    unsigned long type);
 	void	(*f_touch)(struct knote *kn, struct kevent *kev, u_long type);

sys/event.h also followed the rule in all cases until now.

Here, following the rule avoids the ugly split line.

Elsewhere, in recent changes the rule is no longer followed for an unsigned
int.

Bruce