From owner-svn-src-head@freebsd.org Mon Jul 30 18:01:38 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id F2B33105CDDC for ; Mon, 30 Jul 2018 18:01:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 858C07D253 for ; Mon, 30 Jul 2018 18:01:37 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-it0-x22f.google.com with SMTP id d9-v6so501010itf.2 for ; Mon, 30 Jul 2018 11:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=MGjKUZpx9pSI6M3/mM9kLWZUUKNSlGDXAW1770YkHd0=; b=a1+jcresgm6khk4PDSiXrSQ8BBeiTjtZbaEwQUsPDvmMz/qjuTn12Kbmpd/iPzbT3z eu6pVrzt7E6GWPIR2llYErLZgJkSBzLBS+nJlgv3MVaF89+h4piz2uRtbtOfRFpWjTVU 0Lnli3L1rADcTp0sRQCoKokXKeOa/npXRX0QQf5vJ/7AJwPQnAPt3T679AqokKg3Nnzg d3sMUYphMHlICDXQcIZguVpjd2k6dnoZ928eHNGT4LPZohKZfPA9Lb6QFt5T4JkgUYu5 eIis0TwtCEyRMtfsqwmCmZoSskUWvz07MVSDO4IGf+MhyVDqgW8568YPO0u3lWwJ1ndL HStw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=MGjKUZpx9pSI6M3/mM9kLWZUUKNSlGDXAW1770YkHd0=; b=XWebLEIOEEsKuL+AUCJ32xGQQ7Rl5TRILXyDgCieDderaCSgRaGYoSYEcpapSlxfwC c4aRo9ij+D95LMchDiXQgtVyFydHbQfqqlk2mIpCYp/0rSt1t8gNYHEB7z9Q77ps6Oi6 2kyXN8bHjsWfXNJJzhHwSuETLE7epxTYA6XpPFs8o9CDGtRhzEakfpw5Pn2V4rFUjjGv jkY2TA3fHTCl8Vqxk8YFTCxt6SZZjfSVnnuFWsegfgmLYxpT0ffycqStlmj/R6YvQX0f 4ZBrT8hdcPzAbbWNg64JAI/irg2CzKTsN/i8AfuCMVdPPG83J81CA6Ekn4Vu/521EqbI NYSA== X-Gm-Message-State: AOUpUlGsr0YlEunVPa5JEk90eK+3zICN/Ofv0vk+8/A0XofyOkCbEfn4 9Gc/vdwhGI8c8cfJD4R2FCv/Lm8t2MEHKtB6oEfdBQ== X-Google-Smtp-Source: AAOMgpdXir/j8GfX2JIntjtzFDpLjLuZBhwH1nCm+cbSTMcCjUChldElns+CWMorP/AkgZMfFCkHE5RpN/kvSk+Z+Ks= X-Received: by 2002:a24:b211:: with SMTP id u17-v6mr301014ite.1.1532973696920; Mon, 30 Jul 2018 11:01:36 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 2002:a4f:4485:0:0:0:0:0 with HTTP; Mon, 30 Jul 2018 11:01:36 -0700 (PDT) X-Originating-IP: [2603:300b:6:5100:1052:acc7:f9de:2b6d] In-Reply-To: <20180730175923.vtha72pcvzilsspu@mutt-hbsd> References: <201807301740.w6UHeRM0077138@repo.freebsd.org> <20180730175923.vtha72pcvzilsspu@mutt-hbsd> From: Warner Losh Date: Mon, 30 Jul 2018 12:01:36 -0600 X-Google-Sender-Auth: OXbJlzd9IlDRxQc0hr7pxjPPAmo Message-ID: Subject: Re: svn commit: r336919 - head/sys/dev/efidev To: Shawn Webb Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.27 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 30 Jul 2018 18:01:38 -0000 It would be a good idea to make it like the other tuneables. efi.rt.enabled=0 would be the pattern. Warner On Mon, Jul 30, 2018 at 11:59 AM, Shawn Webb wrote: > On Mon, Jul 30, 2018 at 05:40:27PM +0000, Kyle Evans wrote: > > Author: kevans > > Date: Mon Jul 30 17:40:27 2018 > > New Revision: 336919 > > URL: https://svnweb.freebsd.org/changeset/base/336919 > > > > Log: > > efirt: Add tunable to allow disabling EFI Runtime Services > > > > Leading up to enabling EFIRT in GENERIC, allow runtime services to be > > disabled with a new tunable: efi.rt_disabled. This makes it so that > EFIRT > > can be disabled easily in case we run into some buggy UEFI > implementation > > and fail to boot. > > > > Discussed with: imp, kib > > MFC after: 1 week > > > > Modified: > > head/sys/dev/efidev/efirt.c > > > > Modified: head/sys/dev/efidev/efirt.c > > ============================================================ > ================== > > --- head/sys/dev/efidev/efirt.c Mon Jul 30 17:03:15 2018 > (r336918) > > +++ head/sys/dev/efidev/efirt.c Mon Jul 30 17:40:27 2018 > (r336919) > > @@ -133,7 +133,12 @@ efi_init(void) > > struct efi_md *map; > > caddr_t kmdp; > > size_t efisz; > > + int rt_disabled; > > > > + rt_disabled = 0; > > + TUNABLE_INT_FETCH("efi.rt_disabled", &rt_disabled); > > Would it be a good idea to document this tunable in loader(8)? > > Thanks, > > -- > Shawn Webb > Cofounder and Security Engineer > HardenedBSD > > Tor-ified Signal: +1 443-546-8752 > Tor+XMPP+OTR: lattera@is.a.hacker.sx > GPG Key ID: 0x6A84658F52456EEE > GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE >