From owner-svn-src-head@freebsd.org Tue Jul 14 11:32:21 2015 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id D929599C6A0 for ; Tue, 14 Jul 2015 11:32:21 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-oi0-f44.google.com (mail-oi0-f44.google.com [209.85.218.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A8205EF3 for ; Tue, 14 Jul 2015 11:32:21 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by oibn4 with SMTP id n4so4297852oib.3 for ; Tue, 14 Jul 2015 04:32:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=uDC26FwLprJbbsszcEZt7Jer3qu9pqU7Z7eARE+rLxg=; b=K2/DMGf8yISYamnG+0XnQ8DrWkA1AVdbcIfqVa5yF0zFCCuXwrMYoeWuGv8HfqnH7f 2wmc5jh9wmvGfYFxS6yHOrpgNwo7lHuDnH6R7WDLK6MXodP5TvUCm651uU9HPc4ZPLhU A+Bb3ZK4I0r1V5ahvM4ADh9gvCOv/aZM6f0qPUVUxD7VvdJPqNtvm/VpBBSgeDQ5Xcyj hLsMASYjWU0rz83mcx2r3GCmAq/PC10phbRvXQBswKg6Iur+btKB6Lq9/6O9/L5e8QWh sPqsUcpaRLDJJKD+gQBkzGELzeghLHnR7/GdacP8qp6GYJBq8W/7hI+yUFYosOVsh9/w w8PA== X-Gm-Message-State: ALoCoQlPi0yjeHz0ZJ+7JMzIS51kXSOxEOLVtst5+znHLH+k0vXUjNp0rJTpfV6I/G876juw0K3Y MIME-Version: 1.0 X-Received: by 10.202.67.67 with SMTP id q64mr3733002oia.124.1436873540602; Tue, 14 Jul 2015 04:32:20 -0700 (PDT) Received: by 10.76.0.46 with HTTP; Tue, 14 Jul 2015 04:32:20 -0700 (PDT) X-Originating-IP: [84.27.222.46] In-Reply-To: <20150714110126.GV2404@kib.kiev.ua> References: <201507111941.t6BJfV1a072539@repo.freebsd.org> <20150711194732.GB2404@kib.kiev.ua> <20150711205611.GC2404@kib.kiev.ua> <20150714110126.GV2404@kib.kiev.ua> Date: Tue, 14 Jul 2015 13:32:20 +0200 Message-ID: Subject: Re: svn commit: r285404 - head/sys/compat/cloudabi From: Ed Schouten To: Konstantin Belousov Cc: Ed Schouten , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jul 2015 11:32:21 -0000 Hi Kostik, > Exactly. I think that for programs that are built around pipelines, > where a series of processes have stdin/stdout attached, having > something like SIGPIPE makes sense. So far the focus It looks like I accidentally truncated the last sentence. Sorry about that. "So far the focus with CloudABI is on running services, in which stdin/stdout typically don't play a role." 2015-07-14 13:01 GMT+02:00 Konstantin Belousov : > On Tue, Jul 14, 2015 at 12:22:51PM +0200, Ed Schouten wrote: >> Ah, okay. Now I think I understand what you're hinting at. So your >> proposal is to let cloudabi_sys_proc_raise() only call into >> sys_kill(), nothing else. We then reset all signals to their default >> behavior at some point during process startup. >> >> Let me address this by the time I'm sending out the CloudABI sysentvec >> for review, as that would be the place where I'd need to do that. I'll >> remove the call to kern_sigaction() in the meantime. Does that sound >> all right? > > Sounds fine. But, I do not recomment to use sys_kill(), which is > the FreeBSD syscall implementation. You should use pksignal(9) or > similar function directly, IMO. Minor code duplication to create > proper ksiginfo is not critical, while you do not need pfind() or > complications with negative pid values. That sounds like a good idea. I just sent you a code review: https://reviews.freebsd.org/D3076 Thanks for your time! -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK/VAT number: 62051717