From owner-cvs-all  Wed Jun 10 05:10:49 1998
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Received: (from majordom@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id FAA12894
          for cvs-all-outgoing; Wed, 10 Jun 1998 05:10:49 -0700 (PDT)
          (envelope-from owner-cvs-all@FreeBSD.ORG)
Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.15.68.22])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id FAA12653;
          Wed, 10 Jun 1998 05:09:39 -0700 (PDT)
          (envelope-from bde@godzilla.zeta.org.au)
Received: (from bde@localhost)
	by godzilla.zeta.org.au (8.8.7/8.8.7) id WAA17030;
	Wed, 10 Jun 1998 22:09:31 +1000
Date: Wed, 10 Jun 1998 22:09:31 +1000
From: Bruce Evans <bde@zeta.org.au>
Message-Id: <199806101209.WAA17030@godzilla.zeta.org.au>
To: cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG,
        dt@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/msdosfs msdosfs_vnops.c
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk

>  Modified files:
>    sys/msdosfs          msdosfs_vnops.c 
>  Log:
>  Also return EOPNOTSUPP rather than EINVAL for not supported owner and group
>  changes.

This is wrong in several ways:
- the operation is supported, but certain values are invalid.
- EOPNOTSUPP is not mentioned in chown.2 or chgrp.2.  EINVAL is documented
  as the error for fchown() on a socket.
- EOPNOTSUPP is not a POSIX errno.  Although msdosfs can't support full
  POSIX semantics, it should be as POSIX-like as possible

Chflags doesn't have so much history beind not returning EOPNOTSUPP, but
EOPNOTSUPP is not mentioned in chflags.2 and EINVAL is documented as the
error for fchflags() on a socket.

Bruce

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message