From owner-cvs-src@FreeBSD.ORG  Thu May 25 14:55:17 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 80A9D16A598;
	Thu, 25 May 2006 14:55:17 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.FreeBSD.org (Postfix) with ESMTP id C604243D7D;
	Thu, 25 May 2006 14:55:10 +0000 (GMT) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id k4PEt9Ab078751
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Thu, 25 May 2006 07:55:10 -0700 (PDT) (envelope-from sam@errno.com)
Message-ID: <4475C54D.5040009@errno.com>
Date: Thu, 25 May 2006 07:55:09 -0700
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.2 (X11/20060508)
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <200605242211.k4OMB8rY077596@repoman.freebsd.org>
	<20060525111300.GJ27819@FreeBSD.org>
In-Reply-To: <20060525111300.GJ27819@FreeBSD.org>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/kern subr_taskqueue.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 25 May 2006 14:55:17 -0000

Gleb Smirnoff wrote:
>   Sam,
> 
> On Wed, May 24, 2006 at 10:11:08PM +0000, Sam Leffler wrote:
> S> sam         2006-05-24 22:11:08 UTC
> S> 
> S>   FreeBSD src repository
> S> 
> S>   Modified files:
> S>     sys/kern             subr_taskqueue.c 
> S>   Log:
> S>   When starting up threads in taskqueue_start_threads create them
> S>   stopped before adjusting their priority and setting them on the run
> S>   q so they cannot race for resources (pointed out by njl).
> S>   
> S>   While here add a console printf on thread create fails; otherwise
> S>   noone may notice (e.g. return value is always 0 and caller has no
> S>   way to verify).
> S>   
> S>   Reviewed by:    jhb, scottl
> S>   MFC after:      2 weeks
> 
> Since "pointed out by njl", I hope that this fix for the ACPI problem that
> prevented merging the new taskqueue code to RELENG_6?

It's unlikely, but jhb's changes to correct priority propagation might
have helped.  We were never able to get enough information to diagnose
the ACPI problem.

	Sam