Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 01 Nov 2017 07:53:50 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-fs@FreeBSD.org
Subject:   [Bug 223348] Inode number for directories change to inode number of directory two levels up causing hierarchy loop
Message-ID:  <bug-223348-3630-Ky2EqjN6Yq@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-223348-3630@https.bugs.freebsd.org/bugzilla/>
References:  <bug-223348-3630@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D223348

Andriy Gapon <avg@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mjg@FreeBSD.org

--- Comment #3 from Andriy Gapon <avg@FreeBSD.org> ---
And when you know what you are looking for:

static __noinline int
cache_lookup_nomakeentry(struct vnode *dvp, struct vnode **vpp,
    struct componentname *cnp, struct timespec *tsp, int *ticksp)
{
        struct namecache *ncp;
        struct rwlock *blp;
        struct mtx *dvlp, *dvlp2;
        uint32_t hash;
        int error;

        if (cnp->cn_namelen =3D=3D 2 && cnp->cn_nameptr[1] =3D=3D '.') {

There is a similar condition in cache_lookup() as well.

I do not see any code to pre-check that cnp->cn_nameptr[0] =3D=3D '.'

Seems like bad refactoring in r324378.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-223348-3630-Ky2EqjN6Yq>