From owner-freebsd-bugs@FreeBSD.ORG Wed Mar 9 16:23:14 2005 Return-Path: Delivered-To: freebsd-bugs@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7745F16A4CE for ; Wed, 9 Mar 2005 16:23:14 +0000 (GMT) Received: from mail.digitalworx.net (mail.digitalworx.net [209.90.82.130]) by mx1.FreeBSD.org (Postfix) with ESMTP id C3E0643D31 for ; Wed, 9 Mar 2005 16:23:13 +0000 (GMT) (envelope-from danallen46@airwired.net) Received: (qmail 1668 invoked by uid 508); 9 Mar 2005 16:23:12 -0000 Received: from unknown (HELO ?192.168.0.24?) (danallen46@airwired.net@216.83.138.247) by 0 with SMTP; 9 Mar 2005 16:23:12 -0000 In-Reply-To: <200503091418.j29EIP4e033478@freefall.freebsd.org> References: <200503091418.j29EIP4e033478@freefall.freebsd.org> Mime-Version: 1.0 (Apple Message framework v619.2) Content-Type: text/plain; charset=US-ASCII; format=flowed Message-Id: <16e5d2d5e1683cd7fd3f4c9e8a3da2e3@airwired.net> Content-Transfer-Encoding: 7bit From: Dan Allen Date: Wed, 9 Mar 2005 09:23:11 -0700 To: Gleb Smirnoff X-Mailer: Apple Mail (2.619.2) cc: freebsd-bugs@FreeBSD.org Subject: Re: kern/78256: strstr could be more robust X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Mar 2005 16:23:14 -0000 On Mar 9, 2005, at 7:18 AM, Gleb Smirnoff wrote: > Synopsis: strstr could be more robust > > State-Changed-From-To: open->closed > State-Changed-By: glebius > State-Changed-When: Wed Mar 9 14:18:01 GMT 2005 > State-Changed-Why: > Not a bug, sorry. See also bin/52691. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=78256 Why are you so reluctant to add one test to improve robustness? Since it is not specified one way or the other in the standard, it will not break compatibility with the standard. So it is not a bug technically - you still could with a single line of C code improve the robustness of the system. Not doing so seems shortsighted. Dan