From owner-freebsd-current Sat May 26 21:15:40 2001 Delivered-To: freebsd-current@freebsd.org Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138]) by hub.freebsd.org (Postfix) with ESMTP id 46AF837B422 for ; Sat, 26 May 2001 21:15:37 -0700 (PDT) (envelope-from dima@unixfreak.org) Received: from hornet.unixfreak.org (hornet [63.198.170.140]) by bazooka.unixfreak.org (Postfix) with ESMTP id 7D9813E28 for ; Sat, 26 May 2001 21:15:36 -0700 (PDT) To: current@freebsd.org Subject: Re: kbdcontrol the build-tool revisited (was: cvs commit: src/usr.sbin/kbdcontrol kbdcontrol.c) In-Reply-To: <200105270403.f4R43r843630@freefall.freebsd.org>; from dd@FreeBSD.org on "Sat, 26 May 2001 21:03:53 -0700 (PDT)" Date: Sat, 26 May 2001 21:15:36 -0700 From: Dima Dorfman Message-Id: <20010527041536.7D9813E28@bazooka.unixfreak.org> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Hi folks, As I'm sure most people here know, kbdcontrol is a build-tool because sysinstall requires it to generate keymap.h. This means that it has to compile with the headers already in /usr/include on the host system; the last time this came up with PASTE, we just defined the needed constant in kbdcontrol.c and forgot about the problem. This is rather silly, because it effectively means we can't add new features to kbdcontrol that depend on new header files. Furthermore, sysinstall only needs a small subset of its features, which can be easily factored out into a separate program. This has been proposed before; nobody really objected, but it was found that defining the constant was much quicker and easier. Since I think being unable to add new features to kbdcontrol is a rather silly limitation, I again propose to factor out `kbdcontrol -L` into a separate program, which can then be made a build-tool. I'll do all the work necessary if this is what we want to do. Regards, Dima Dorfman dima@unixfreak.org Dima Dorfman writes: > dd 2001/05/26 21:03:53 PDT > > Modified files: > usr.sbin/kbdcontrol kbdcontrol.c > Log: > A la rev. 1.36, define CONS_CLRHIST here if it isn't already since > this is a build tool, so it has to build on 4.x with the old headers. > > Revision Changes Path > 1.38 +7 -3 src/usr.sbin/kbdcontrol/kbdcontrol.c > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message