From owner-svn-src-all@freebsd.org Tue Jun 14 16:37:21 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7D7FFB7214E; Tue, 14 Jun 2016 16:37:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 618772B86; Tue, 14 Jun 2016 16:37:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [IPv6:::1]) by freefall.freebsd.org (Postfix) with ESMTP id 53BF018D2; Tue, 14 Jun 2016 16:37:21 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id 1BBFC1DD92; Tue, 14 Jun 2016 16:37:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id sZrGvBSBy9fI; Tue, 14 Jun 2016 16:37:17 +0000 (UTC) Subject: Re: svn commit: r301602 - in head: . lib/libpam lib/libpam/libpam lib/libpam/libpam/security tools/build/mk DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com A89421DD8D To: Ngie Cooper , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= References: <201606081147.u58BlJ8X099462@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Organization: FreeBSD Message-ID: <15ae4cc5-c65f-49af-5456-07d2cf476337@FreeBSD.org> Date: Tue, 14 Jun 2016 09:37:17 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="KeaqhvPNSk8MW9FHQcVm2BlulG1bWRDab" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Jun 2016 16:37:21 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --KeaqhvPNSk8MW9FHQcVm2BlulG1bWRDab Content-Type: multipart/mixed; boundary="do8MRQVSlGrB0UTLqHg92jLcGMJvdk13G" From: Bryan Drewery To: Ngie Cooper , =?UTF-8?Q?Dag-Erling_Sm=c3=b8rgrav?= Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Message-ID: <15ae4cc5-c65f-49af-5456-07d2cf476337@FreeBSD.org> Subject: Re: svn commit: r301602 - in head: . lib/libpam lib/libpam/libpam lib/libpam/libpam/security tools/build/mk References: <201606081147.u58BlJ8X099462@repo.freebsd.org> In-Reply-To: --do8MRQVSlGrB0UTLqHg92jLcGMJvdk13G Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 6/14/2016 9:25 AM, Ngie Cooper wrote: > On Wed, Jun 8, 2016 at 4:47 AM, Dag-Erling Sm=C3=B8rgrav wrote: >> Author: des >> Date: Wed Jun 8 11:47:19 2016 >> New Revision: 301602 >> URL: https://svnweb.freebsd.org/changeset/base/301602 >> >> Log: >> Replace _pam_verbose_error() with a macro. This was the last differ= ence >> between our libpam and stock OpenPAM, meaning that it is now possibl= e to >> replace the base libpam with a hypothetical ports version of OpenPAM= =2E >=20 > Unfortunately this commit wasn't followed by a bump to > __FreeBSD_version, so the package cluster hasn't updated all packages > that require libpam.so, like sudo, etc. >=20 > I can't commit anything for a while (my Macbook Pro is a bit out of > commission)... but I'll try and prod someone else to do it. >=20 Note this will also cause the OpenSSL bump in r301271 to break packages. Ports OpenSSL is supposed to be +1 over what is in base but r301271 made it match... thus rebuilding packages will likely cause chaos. We'll need to fix the OpenSSL port first. Also, I sort of consider this a failure on Poudriere/ports/pkg. We should be able to detect that shared libraries were bumped and some packages need to be rebuilt now. Unfortunately pkg doesn't record the dependency. Poudriere could record it and use it. This goes back to my proposal (which has lacked implementation time) about how to auto-detect when the system ABI changes without relying on __FreeBSD_version. Bumped libraries would have to be one of them. --=20 Regards, Bryan Drewery --do8MRQVSlGrB0UTLqHg92jLcGMJvdk13G-- --KeaqhvPNSk8MW9FHQcVm2BlulG1bWRDab Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEbBAEBAgAGBQJXYDK9AAoJEDXXcbtuRpfPZkwH9ifCwcztS+I+Y/KvYtkvbOWu o9Zr7JWQr5lrDYgvOmyx5pwYPYDpelVX7USBy306lkdCZQ6wJyMUVFFr9JsbAVBc FOtfvLOOJCH0pZ4FmQCJKxgXvsSOmX4fqOnAYJlYiQNnfcQtw4tnYZ8EtMLPHRw1 3WXCMSwsjC8wb1UJLiIHe8F7BWg6pSu8NqDnY/9H/PkpRxh3HxbHfLMmhmIrJpYG gZcTHAceLfYOsOxvcLlNrH1fBg2va9aeXYWCGfbhXZHb6cnwGi5vtCHb1L00Ni5t v3La+RISt51r1pbkuFFBSg7/xMUyJ6flSS4kxqXDRYbdandT849iMpWuzEh+nw== =uWbe -----END PGP SIGNATURE----- --KeaqhvPNSk8MW9FHQcVm2BlulG1bWRDab--