From nobody Fri Jul 15 18:15:07 2022 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Lkzzh24yJz4TJ1g; Fri, 15 Jul 2022 18:15:12 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from drew.franken.de (mail-n.franken.de [193.175.24.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "*.franken.de", Issuer "Sectigo RSA Domain Validation Secure Server CA" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Lkzzg2p4Fz3YWN; Fri, 15 Jul 2022 18:15:11 +0000 (UTC) (envelope-from michael.tuexen@macmic.franken.de) Received: from smtpclient.apple (unknown [IPv6:2a02:8109:1140:c3d:551a:efb8:da73:ffc7]) (Authenticated sender: macmic) by drew.franken.de (Postfix) with ESMTPSA id F18F57B9425BF; Fri, 15 Jul 2022 20:15:07 +0200 (CEST) Content-Type: text/plain; charset=us-ascii List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.100.31\)) Subject: Re: git: 66605ff791b1 - main - tcp: Undo the increase in sequence number by 1 due to the FIN flag in case of a transient error. From: Michael Tuexen In-Reply-To: Date: Fri, 15 Jul 2022 20:15:07 +0200 Cc: Richard Scheffenegger , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: References: <202207151636.26FGaHsM038397@gitrepo.freebsd.org> To: John Baldwin X-Mailer: Apple Mail (2.3696.100.31) X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=disabled version=3.4.1 X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on mail-n.franken.de X-Rspamd-Queue-Id: 4Lkzzg2p4Fz3YWN X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of michael.tuexen@macmic.franken.de has no SPF policy when checking 193.175.24.27) smtp.mailfrom=michael.tuexen@macmic.franken.de X-Spamd-Result: default: False [-1.68 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; NEURAL_HAM_LONG(-1.00)[-1.000]; AUTH_NA(1.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.983]; MV_CASE(0.50)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_IN_DNSWL_LOW(-0.10)[193.175.24.27:from]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; R_DKIM_NA(0.00)[]; ASN(0.00)[asn:680, ipnet:193.174.0.0/15, country:DE]; R_SPF_NA(0.00)[no SPF record]; MLMMJ_DEST(0.00)[dev-commits-src-all,dev-commits-src-main]; FROM_EQ_ENVFROM(0.00)[]; RCPT_COUNT_FIVE(0.00)[5]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_SOME(0.00)[]; DMARC_NA(0.00)[franken.de]; TO_DN_EQ_ADDR_SOME(0.00)[] X-ThisMailContainsUnwantedMimeParts: N > On 15. Jul 2022, at 19:50, John Baldwin wrote: >=20 > On 7/15/22 9:36 AM, Richard Scheffenegger wrote: >> The branch main has been updated by rscheff: >> URL: = https://cgit.FreeBSD.org/src/commit/?id=3D66605ff791b12a2c3bb4570379db0e14= d29fca4c >> commit 66605ff791b12a2c3bb4570379db0e14d29fca4c >> Author: Richard Scheffenegger >> AuthorDate: 2022-07-14 00:49:10 +0000 >> Commit: Richard Scheffenegger >> CommitDate: 2022-07-14 01:18:19 +0000 >> tcp: Undo the increase in sequence number by 1 due to the FIN = flag in case of a transient error. >> If an error occurs while processing a TCP segment with some = data and the FIN >> flag, the back out of the sequence number advance does not take = into account the >> increase by 1 due to the FIN flag. >> Reviewed By: jch, gnn, #transport, tuexen >> Sponsored by: NetApp, Inc. >> Differential Revision: https://reviews.freebsd.org/D2970 >=20 > Is this the source of bug 264257? We don't think so... But a fix for another issues in the problem space = of dealing=20 with the sequence number taken by the FIN bit. Best regards Michael >=20 > --=20 > John Baldwin