From owner-freebsd-mips@FreeBSD.ORG  Sat Jul  4 15:28:54 2009
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1A3A2106566C
	for <freebsd-mips@freebsd.org>; Sat,  4 Jul 2009 15:28:54 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85])
	by mx1.freebsd.org (Postfix) with ESMTP id CF60C8FC0A
	for <freebsd-mips@freebsd.org>; Sat,  4 Jul 2009 15:28:53 +0000 (UTC)
	(envelope-from imp@bsdimp.com)
Received: from localhost (localhost [127.0.0.1])
	by harmony.bsdimp.com (8.14.3/8.14.1) with ESMTP id n64FPSgV080144;
	Sat, 4 Jul 2009 09:25:28 -0600 (MDT) (envelope-from imp@bsdimp.com)
Date: Sat, 04 Jul 2009 09:25:59 -0600 (MDT)
Message-Id: <20090704.092559.353389034.imp@bsdimp.com>
To: neelnatu@yahoo.com
From: "M. Warner Losh" <imp@bsdimp.com>
In-Reply-To: <385015.11949.qm@web34404.mail.mud.yahoo.com>
References: <385015.11949.qm@web34404.mail.mud.yahoo.com>
X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Cc: freebsd-mips@freebsd.org
Subject: Re: Machine Check exception during bootup
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jul 2009 15:28:54 -0000

In message: <385015.11949.qm@web34404.mail.mud.yahoo.com>
            Neelkanth Natu <neelnatu@yahoo.com> writes:
: 
: Hi Warner,
: 
: --- On Fri, 7/3/09, M. Warner Losh <imp@bsdimp.com> wrote:
: 
: > From: M. Warner Losh <imp@bsdimp.com>
: > Subject: Re: Machine Check exception during bootup
: > To: neelnatu@yahoo.com
: > Cc: freebsd-mips@freebsd.org
: > Date: Friday, July 3, 2009, 8:11 PM
: > In message: <122643.47019.qm@web34403.mail.mud.yahoo.com>
: >             Neelkanth Natu
: > <neelnatu@yahoo.com>
: > writes:
: > : ====
: > //depot/user/neelnatu/freebsd_sibyte/src/sys/mips/mips/genassym.c#1
: > - /u/neelnatu/p4/freebsd_sibyte/src/sys/mips/mips/genassym.c
: > ====
: > : @@ -91,6 +91,7 @@
: > :  ASSYM(SIGF_UC, offsetof(struct sigframe, sf_uc));
: > :  ASSYM(SIGFPE, SIGFPE);
: > :  ASSYM(PGSHIFT, PGSHIFT);
: > : +ASSYM(PAGE_SHIFT, PAGE_SHIFT);
: > :  ASSYM(NBPG, NBPG);
: > :  ASSYM(SEGSHIFT, SEGSHIFT);
: > :  ASSYM(NPTEPG, NPTEPG);
: > 
: > How do PAGE_SHIFT and PGSHIFT differ?
: 
: They are identical. I looked at other architectures and it seems that
: PGSHIFT is a macro defined for mips alone. The same is true for
: PGOFSET and PAGE_MASK.
: 
: So I went with the obvious macro - PAGE_SHIFT.
: 
: I think we should toast PGSHIFT and PGOFFSET and replace them with
: PAGE_SHIFT and PAGE_MASK respectively. What do you think?

This sounds like a good cleanup item...

Warner