From owner-freebsd-bugs Tue Jul 10 22:10: 8 2001 Delivered-To: freebsd-bugs@hub.freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id EEB3F37B403 for ; Tue, 10 Jul 2001 22:10:01 -0700 (PDT) (envelope-from gnats@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.11.3/8.11.3) id f6B5A1W98728; Tue, 10 Jul 2001 22:10:01 -0700 (PDT) (envelope-from gnats) Date: Tue, 10 Jul 2001 22:10:01 -0700 (PDT) Message-Id: <200107110510.f6B5A1W98728@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org Cc: From: Gregory Bond Subject: Re: bin/28885: [patch] enhance makekey to check/generate MD5 passwords Reply-To: Gregory Bond Sender: owner-freebsd-bugs@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org The following reply was made to PR bin/28885; it has been noted by GNATS. From: Gregory Bond To: Dima Dorfman Cc: FreeBSD-gnats-submit@freebsd.org Subject: Re: bin/28885: [patch] enhance makekey to check/generate MD5 passwords Date: Wed, 11 Jul 2001 15:02:42 +1000 >I don't think this is desired. makekey is a very simple program with >a very simple purpose: to take a salt and a string and produce a DES >hash. I understand this, but I did ask for suggestions and got none better! It seems crazy this function is not available anywhere in the base system, thus forcing application writers to reinvent this particular wheel, usually in a way that is not compatible with FreeBSD's evolving crypto infrastructure. I can see 6 ways forward: 1 - Accept the patches to makekey 2 - Develop equivalent patches to pw(8) 3 - Produce a new program in the base system for just this job 4 - Produce a new port for this job 5 - Ignore the problem and stick with the status quo. 6 - Decide it's not a problem at all I've done #1, I'm happy to do either #2 or #3 if TPTB think it is better and it might get committed, but #4 and #5 don't seem to fill this (perceived?) need. In particular, #4 won't be widely used by other application writers. I don't think #6 is true because I was bit by this problem and motivated to produce this PR! > For an example of how it's supposed to be used, see > src/usr.bin/enigma/enigma.c (and I think your patch even breaks this > case). It shouldn't. If no args are present, then the patched version calls the exact same code as the original. Quick tests indicate enigma still works as expected. Greg. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message