From owner-svn-src-all@FreeBSD.ORG Mon Feb 3 17:03:32 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 1770A1EF; Mon, 3 Feb 2014 17:03:32 +0000 (UTC) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id CF7371C64; Mon, 3 Feb 2014 17:03:31 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id s13H3UF9099157 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 3 Feb 2014 09:03:31 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id s13H3UIo099156; Mon, 3 Feb 2014 09:03:30 -0800 (PST) (envelope-from jmg) Date: Mon, 3 Feb 2014 09:03:30 -0800 From: John-Mark Gurney To: Ian Lepore Subject: Re: svn commit: r261424 - head/sys/dev/mmc Message-ID: <20140203170330.GC89104@funkthat.com> References: <201402030256.s132uNjk086555@svn.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201402030256.s132uNjk086555@svn.freebsd.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-TipJar: bitcoin:13Qmb6AeTgQecazTWph4XasEsP7nGRbAPE X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Mon, 03 Feb 2014 09:03:31 -0800 (PST) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Feb 2014 17:03:32 -0000 Ian Lepore wrote this message on Mon, Feb 03, 2014 at 02:56 +0000: > Author: ian > Date: Mon Feb 3 02:56:23 2014 > New Revision: 261424 > URL: http://svnweb.freebsd.org/changeset/base/261424 > > Log: > Sort the list. > > Modified: > head/sys/dev/mmc/mmc.c > > Modified: head/sys/dev/mmc/mmc.c > ============================================================================== > --- head/sys/dev/mmc/mmc.c Mon Feb 3 02:52:07 2014 (r261423) > +++ head/sys/dev/mmc/mmc.c Mon Feb 3 02:56:23 2014 (r261424) > @@ -1756,10 +1756,11 @@ static driver_t mmc_driver = { > }; > static devclass_t mmc_devclass; > > -DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > DRIVER_MODULE(mmc, at91_mci, mmc_driver, mmc_devclass, NULL, NULL); > -DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > DRIVER_MODULE(mmc, sdhci_bcm, mmc_driver, mmc_devclass, NULL, NULL); > DRIVER_MODULE(mmc, sdhci_fdt, mmc_driver, mmc_devclass, NULL, NULL); > -DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > DRIVER_MODULE(mmc, sdhci_imx, mmc_driver, mmc_devclass, NULL, NULL); > +DRIVER_MODULE(mmc, sdhci_pci, mmc_driver, mmc_devclass, NULL, NULL); > +DRIVER_MODULE(mmc, sdhci_ti, mmc_driver, mmc_devclass, NULL, NULL); > +DRIVER_MODULE(mmc, ti_mmchs, mmc_driver, mmc_devclass, NULL, NULL); > + Is there a reason we don't make mmc_driver/mmc_devclass global and put all of these defines in their respective file instead of poluting an MI file w/ MD info? -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."