From owner-cvs-all@FreeBSD.ORG  Sun Oct 31 05:56:30 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id E618616A4CE; Sun, 31 Oct 2004 05:56:30 +0000 (GMT)
Received: from elvis.mu.org (elvis.mu.org [192.203.228.196])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id C551B43D31; Sun, 31 Oct 2004 05:56:30 +0000 (GMT)
	(envelope-from bright@elvis.mu.org)
Received: by elvis.mu.org (Postfix, from userid 1192)
	id BDE515D17C; Sat, 30 Oct 2004 22:56:30 -0700 (PDT)
Date: Sat, 30 Oct 2004 22:56:30 -0700
From: Alfred Perlstein <alfred@freebsd.org>
To: Brian Fundakowski Feldman <green@FreeBSD.org>
Message-ID: <20041031055630.GE24892@elvis.mu.org>
References: <200410310503.i9V53ofj011896@repoman.freebsd.org>
	<20041031050620.GQ93831@green.homeunix.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20041031050620.GQ93831@green.homeunix.org>
User-Agent: Mutt/1.4.2.1i
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/lib/libpthread/thread thr_mutex.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Oct 2004 05:56:31 -0000

* Brian Fundakowski Feldman <green@FreeBSD.org> [041030 22:06] wrote:
> On Sun, Oct 31, 2004 at 05:03:50AM +0000, Brian Feldman wrote:
> > green       2004-10-31 05:03:50 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     lib/libpthread/thread thr_mutex.c 
> >   Log:
> >   Make pthread_mutex_trylock(3) return EBUSY on failure, as all software
> >   packages expect and seems to be most correct according to the slightly-
> >   ambiguous standards.
> >   
> >   MFC after:              1 month
> >   Corroborated by:        POSIX <http://tinyurl.com/4uvub>
> >   Reviewed by:            silence on threads@
> 
> Software such as mozilla projects (using NSPR) and Java have been
> broken in various ways by this.  We need to try to be more compatible
> with the most popular interpretation of the standards (instead of just
> inventing our own) -- usually we're pretty good about this.

Good catch... it could have just been an oversight though. :)

We need a "configure" like regression suite for pthreads[*].

[*] and a ton of other stuff. :)

-- 
- Alfred Perlstein
- Research Engineering Development Inc.
- email: bright@mu.org cell: 408-480-4684