From owner-freebsd-current@freebsd.org Sat Feb 16 15:31:20 2019 Return-Path: Delivered-To: freebsd-current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id E984314EAD9D for ; Sat, 16 Feb 2019 15:31:19 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 576518F011 for ; Sat, 16 Feb 2019 15:31:19 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: by mailman.ysv.freebsd.org (Postfix) id 1AC8B14EAD9C; Sat, 16 Feb 2019 15:31:19 +0000 (UTC) Delivered-To: current@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 0804914EAD99 for ; Sat, 16 Feb 2019 15:31:19 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 770588F00E for ; Sat, 16 Feb 2019 15:31:17 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id x1GFVC9c096693; Sat, 16 Feb 2019 07:31:13 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id x1GFVC2b096692; Sat, 16 Feb 2019 07:31:12 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201902161531.x1GFVC2b096692@pdx.rh.CN85.dnsmgr.net> Subject: Re: problem building dev/e1000 In-Reply-To: <77EDD0AB-BAAC-460F-B2E1-46ABA5045178@gmail.com> To: Enji Cooper Date: Sat, 16 Feb 2019 07:31:12 -0800 (PST) CC: Robert Huff , current@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 770588F00E X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-7.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-1.00)[-0.997,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 16 Feb 2019 15:31:20 -0000 > > > On Feb 15, 2019, at 11:47, Robert Huff wrote: > > > > Lev Serebryakov writes: > > > >>> My question would be: why? If some drivers have a new > >>> dependency on iflib, why isn't that expressed in sys/conf/files > >>> and handled automatically? As expressed elsewhere that gets a bit messy when it is more than just a few things that depend on this module, and historically has been done by adding comments to GENERIC that describe the dependency in the form of "requires iflib". Though there are some ideas floating around that might better address this, for the time being that is how it is being handled. > >> My question exactly. > > > > I am so glad people who know what they're talking about have the > > same response I did. :-) > > I totally missed the part where Robert said he was compiling it > into the kernel. Also, I remember the days when drivers didn?t > automatically compile in dependent options (example: ?device re? > requires ?device miibus?). I guess things have changed a bit in > the past year [while I was away] with some drivers? > Thanks, > -Enji > > Respectcfully, > > Robert Huff Nothing has changed, other than we now have another miibus type thing called iflib and there are a half dozen drivers that need to have iflib compiled in if you use them. What is new is that these drivers already existed in the past, but have been re-written to use iflib, so if your carrying an old kernel config file around and update accross the iflib'ification of that driver you have to pick up the change that went into GENERIC that pulls in iflib. These are probably the types of changes that we should consider not merging to something called stable/. -- Rod Grimes rgrimes@freebsd.org