From owner-freebsd-current@FreeBSD.ORG  Fri Aug 31 09:06:48 2012
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 52A9C106566C;
	Fri, 31 Aug 2012 09:06:48 +0000 (UTC)
	(envelope-from deeptech71@gmail.com)
Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com
	[209.85.214.54])
	by mx1.freebsd.org (Postfix) with ESMTP id A81CB8FC08;
	Fri, 31 Aug 2012 09:06:47 +0000 (UTC)
Received: by bkcje9 with SMTP id je9so1425046bkc.13
	for <multiple recipients>; Fri, 31 Aug 2012 02:06:40 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=message-id:date:from:user-agent:mime-version:to:cc:subject
	:references:in-reply-to:content-type:content-transfer-encoding;
	bh=kcpNM9ym+PNQP3mlZ60GUGgecsH7rc/qY/ic/c24ufk=;
	b=q1956WUiZkOgBKXhE7gj61yGHvc1D+29pZQNSatB7nBApfEelckoxSG7yWCUAGAb7C
	FR3m2Cmfm2UwIWzj4KQISGTIHwcPjI5ylk2fu0PMVovwkLstBXw4rarvQsG5wWuLj84R
	jKOhkCdZUKzBLi6vADn4lL7F1ecbE5ePAFXfazpd/FjsdiDPhYK8y8JuC6wikuR01zZN
	fn07tq2+bcdfaYYvkAEBm1nqTUHgFHYwkuYHaWT+nfR/dMEj8YNenfnskMsyHjr/bGJB
	+P+V3rTJ6irJk9WLtGsW21ru4nXL7Xy0+OXMDX0CObBW/NNS2nvwC9n1rZym5VCGrTso
	0WDw==
Received: by 10.205.129.17 with SMTP id hg17mr3852265bkc.88.1346404000667;
	Fri, 31 Aug 2012 02:06:40 -0700 (PDT)
Received: from [192.168.1.80] (BC06D641.dsl.pool.telekom.hu. [188.6.214.65])
	by mx.google.com with ESMTPS id 14sm2909100bkw.15.2012.08.31.02.06.39
	(version=SSLv3 cipher=OTHER); Fri, 31 Aug 2012 02:06:39 -0700 (PDT)
Message-ID: <5040801D.9090305@gmail.com>
Date: Fri, 31 Aug 2012 11:13:01 +0200
From: deeptech71@gmail.com
User-Agent: Mozilla/5.0 (X11; FreeBSD i386;
	rv:14.0) Gecko/20120802 Firefox/14.0.1 SeaMonkey/2.11
MIME-Version: 1.0
To: Dimitry Andric <dimitry@andric.com>
References: <504068F2.6010300@gmail.com> <50407947.50907@andric.com>
In-Reply-To: <50407947.50907@andric.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: freebsd-current@FreeBSD.org
Subject: Re: sys/dev/amr build error with Clang
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 31 Aug 2012 09:06:48 -0000

Dimitry Andric wrote:
> The one call to get the callout to amr_periodic() started seems to have
> been commented out in r239912:
>
>    http://svnweb.freebsd.org/base/head/sys/dev/amr/amr.c?r1=239912&r2=239911&pathrev=239912
>
> If the function isn't necessary anymore, it could just be deleted, or
> #ifdef'd out.

I don't use "amr", so I personally don't care whether the use of the function was accidentally commented out or whether the function was accidentally left unused. But on a side-note, to a programmer not familiar with the driver, that case seems like a case of "the use was accidentally commented out".