From nobody Mon Feb 9 16:28:38 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f8qrR09rjz6RgMY for ; Mon, 09 Feb 2026 16:28:39 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f8qrQ5LqJz3PYC for ; Mon, 09 Feb 2026 16:28:38 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770654518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZS+IRcjQ9GPyALmAfbUkF1KulmQyIfQN6Br7QjlH4VY=; b=qvmKbvHR5swj8S1k+i7wMQ8KNgmQNf/PjmN99ZQEFSKGaJFfBxjonCD5ZQ4rRIJrHOrRBF HL9pL6Mh5Fd1yacEEAniUm0TJ0PLF3lFsgPkNYuYUz2kaPayygYMDr0QAnBfqJh53b/CL2 n+t8qlbcGpSZVOBU/ZCRuabUAhcr84d1ehEIG3MZSug/jE7BKSdq59XX0DkhE++LDHLW2g GaFCuvlez1YxX6fUqJyZjGuZa8HKeXp5XdauXdxI8WPTTQXhwic8thEWcP2xDjHsY1SJxc MQ9XgT7I9zLZBVRGdwP0U/F8dkGMQpqECALPwDq6ZcV9QrdbhXUs7sfx1/28Gg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770654518; a=rsa-sha256; cv=none; b=ah3Ld7dYWQQzr2X7C/pdrt8SQ/RDxvGwqw4Qd1CW1zDC59AlAOL4KDXJ1QoG2iOFWotkiG mk+QVOftLKv14/qAgjG8Eh4CONnO8XMSqBZeAWBq1UsXr3MQyQNHRWTX8TaNG2a4ZktCJ+ zsC7nWKTnffzbjMeAfHk3r0xY3gn04rlWdoAu0OYzaGH7xna8S6MK8gpuhOuq5kSUFdCqj qpOAdVuug1oh4oJJ+SRs7wvG6Zc9suDUMpsKJtDwMH3RrVyjr//73lxIqLOY5iVWcAzpEm c8Jxo8uTaLfWbquX3e1x/NMUbraIhrXP0Hs52GxksJtM68n0BhgxGFnv85l1Jg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770654518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZS+IRcjQ9GPyALmAfbUkF1KulmQyIfQN6Br7QjlH4VY=; b=B2BXsYugBVyhA/avbzSELnEVK+HPIYbSyiqPtdr0xNK4wWwJJOQyv8qnyY617E4trML8lC QbTPdTewGEqh/TSUYNUeBS6Lh9ul+AivI0kPNC3LeXQrYKG8gU1k5dT2HQAXP0I84dfPMs ecbsRCBc1YbhEiRc3c6pgUg/HVh/dbv9jLIHzW2Bitj+2xEScfnQE3kV37JFKv3smNOyCd hzSk1CW/LBGsZan5PQICHXsjYSnI8DaymBDPWlHw1Wa+vK0ufyL0Y0IEoL5IW8FaM0v4RL u2cRV5EQHcBnTROe1RVB+Udlxk4h46RmrnkiH6DgGiL1h0zu8wIwkd0Lb9z8lw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f8qrQ4hxtzgyx for ; Mon, 09 Feb 2026 16:28:38 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 1d8a7 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Mon, 09 Feb 2026 16:28:38 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Cc: Andy Carrel From: Andrew Turner Subject: git: c70a68bbdbf6 - stable/15 - arm64: Fix kernel panic in get_arm64_sve during core dump List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: andrew X-Git-Repository: src X-Git-Refname: refs/heads/stable/15 X-Git-Reftype: branch X-Git-Commit: c70a68bbdbf67e10a8cd8d46857cc6d4533096a9 Auto-Submitted: auto-generated Date: Mon, 09 Feb 2026 16:28:38 +0000 Message-Id: <698a0b36.1d8a7.25fad201@gitrepo.freebsd.org> The branch stable/15 has been updated by andrew: URL: https://cgit.FreeBSD.org/src/commit/?id=c70a68bbdbf67e10a8cd8d46857cc6d4533096a9 commit c70a68bbdbf67e10a8cd8d46857cc6d4533096a9 Author: Andy Carrel AuthorDate: 2026-01-05 07:50:27 +0000 Commit: Andrew Turner CommitDate: 2026-02-09 14:51:59 +0000 arm64: Fix kernel panic in get_arm64_sve during core dump The coredump logic calls get_arm64_sve twice: once to get the note size, and once to get the data. The note size calculation depended on the volatile `PCB_FP_SVEVALID` flag. If this flag was cleared between the two calls (e.g., due to a context switch clearing the flag to comply with the ABI), the second call would expect a smaller buffer size than the first, triggering a KASSERT panic ("invalid size"). Fix this by ensuring the SVE state is saved to the PCB before we decide whether to use SVE or VFP. PR: 292195 Reviewed by: andrew Differential Revision: https://reviews.freebsd.org/D54532 (cherry picked from commit 93d3ac1daa0ef3ac54ffcd5cc64a14638d04bd60) --- sys/arm64/arm64/vfp.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/arm64/arm64/vfp.c b/sys/arm64/arm64/vfp.c index bcddebfaf66e..64f13458e2d9 100644 --- a/sys/arm64/arm64/vfp.c +++ b/sys/arm64/arm64/vfp.c @@ -934,6 +934,9 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, pcb = td->td_pcb; + if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) + vfp_save_state(td, pcb); + /* If there is no SVE support in HW then we don't support NT_ARM_SVE */ if (pcb->pcb_sve_len == 0) return (false); @@ -955,9 +958,6 @@ get_arm64_sve(struct regset *rs, struct thread *td, void *buf, KASSERT(*sizep == sizeof(struct svereg_header) + buf_size, ("%s: invalid size", __func__)); - if (td == curthread && (pcb->pcb_fpflags & PCB_FP_STARTED) != 0) - vfp_save_state(td, pcb); - header = buf; memset(header, 0, sizeof(*header));