From owner-freebsd-bugs@freebsd.org Fri Apr 17 21:27:53 2020 Return-Path: Delivered-To: freebsd-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7866D2AB5D6 for ; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 493q212dkJz3HrW for ; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 5A75A2AB5D4; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) Delivered-To: bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5A38A2AB5D3 for ; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 493q211kfGz3HrT for ; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 1E4B8FC5 for ; Fri, 17 Apr 2020 21:27:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 03HLRrTG048201 for ; Fri, 17 Apr 2020 21:27:53 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 03HLRqBd048200 for bugs@FreeBSD.org; Fri, 17 Apr 2020 21:27:52 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 245712] iflib: ift_mtx_name is too small Date: Fri, 17 Apr 2020 21:27:53 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: ghuckriede@blackberry.com X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Apr 2020 21:27:53 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245712 Bug ID: 245712 Summary: iflib: ift_mtx_name is too small Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: ghuckriede@blackberry.com Overview: 'ift_mtx_name' https://svnweb.freebsd.org/base/head/sys/net/iflib.c?annotate=3D359436#l362= has size of 16 bytes When it is initialized https://svnweb.freebsd.org/base/head/sys/net/iflib.c?annotate=3D359436#l552= 2 the format string "%s:TX(%d):callout" already uses 14 of those bytes (including= the NULL terminator). This leaves 2 bytes for the 'nameunit' string and the 'ift_id' number, which clearly is not enough. I see 2 possible fixes: 1. Increase the 'ift_mtx_name' array size ('nameunit' is not really a fixed size, so how much?). 2. Change 'ift_mtx_name' to a pointer and alloc an appropriately sized stri= ng, and free it on destroy. Actual Results: 'ift_mtx_name' is truncated even in the best case (i.e. 2 character interfa= ce name). e.g. "em0:TX(0):callo" Expected Results: No truncation. Build Date & Hardware: # uname -a FreeBSD FreeBSD_head_ghuckriede 13.0-CURRENT FreeBSD 13.0-CURRENT #2 r36001= 7: Fri Apr 17 11:16:38 EDT 2020 ghuckriede@FreeBSD_head_ghuckriede:/usr/obj/usr/src/amd64.amd64/sys/GENERIC= =20 amd64 Additional Builds and Platforms: na Additional Information: na --=20 You are receiving this mail because: You are the assignee for the bug.=