From owner-freebsd-current Tue Oct 1 19: 2:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 59DA337B401; Tue, 1 Oct 2002 19:02:38 -0700 (PDT) Received: from freesbee.wheel.dk (freesbee.wheel.dk [193.162.159.97]) by mx1.FreeBSD.org (Postfix) with ESMTP id A052143E3B; Tue, 1 Oct 2002 19:02:37 -0700 (PDT) (envelope-from ncbp@bank-pedersen.dk) Received: by freesbee.wheel.dk (Postfix, from userid 1002) id 4625438347; Wed, 2 Oct 2002 04:02:36 +0200 (CEST) Date: Wed, 2 Oct 2002 04:02:36 +0200 From: "Niels Chr. Bank-Pedersen" To: Mitsuru IWASAKI Cc: jhb@FreeBSD.ORG, mmcgoldrick@linuxdriven.net, current@FreeBSD.ORG Subject: Re: PCI brokenness Message-ID: <20021002020235.GA47844@bank-pedersen.dk> Mail-Followup-To: "Niels Chr. Bank-Pedersen" , Mitsuru IWASAKI , jhb@FreeBSD.ORG, mmcgoldrick@linuxdriven.net, current@FreeBSD.ORG References: <20021001211543.GA607@uriel.fakedomain.net> <20021002.084110.69705085.iwasaki@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20021002.084110.69705085.iwasaki@jp.FreeBSD.org> User-Agent: Mutt/1.4i X-PGP-Fingerprint: 18D0 73F3 767F 3A40 CEBA C595 4783 D7F5 5DD1 FB8C X-PGP-Public-Key: http://freesbee.wheel.dk/~ncbp/gpgkey.pub Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Oct 02, 2002 at 08:41:10AM +0900, Mitsuru IWASAKI wrote: > Hi, > [...] > > Can you try with the stuff I committed yesterday? It fixed the case (for > > my tests at least) of legacy0 failing to attach or probe when acpi failed > > to attach. > > If still failed, please try this. > I've noticed that no chance to call pci_cfgregopen() before probing > PCI children in case Host PCI bridge _CRS is not method or _INI method > don't access to PCI config space or something. > > Thanks > > Index: acpi_pcib_acpi.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_acpi.c,v > retrieving revision 1.23 > diff -u -r1.23 acpi_pcib_acpi.c > --- acpi_pcib_acpi.c 26 Aug 2002 18:30:27 -0000 1.23 > +++ acpi_pcib_acpi.c 1 Oct 2002 23:17:51 -0000 > @@ -114,6 +115,9 @@ > !acpi_disabled("pci") && > acpi_MatchHid(dev, "PNP0A03")) { > > + if (!pci_cfgregopen()) > + return(ENXIO); > + > /* > * Set device description > */ > Index: acpi_pcib_pci.c > =================================================================== > RCS file: /home/ncvs/src/sys/dev/acpica/acpi_pcib_pci.c,v > retrieving revision 1.1 > diff -u -r1.1 acpi_pcib_pci.c > --- acpi_pcib_pci.c 26 Aug 2002 18:30:27 -0000 1.1 > +++ acpi_pcib_pci.c 1 Oct 2002 23:18:38 -0000 > @@ -114,6 +115,9 @@ > return (ENXIO); > if (acpi_get_handle(dev) == NULL) > return (ENXIO); > + if (!pci_cfgregopen()) > + return (ENXIO); > + > device_set_desc(dev, "ACPI PCI-PCI bridge"); > return (-1000); > } Thanks! - this patch fixes the problems I've had with missing PCI devices. Regards, Niels Chr. -- Niels Christian Bank-Pedersen, NCB1-RIPE. "Hey, are any of you guys out there actually *using* RFC 2549?" To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message