From owner-p4-projects@FreeBSD.ORG Tue Jun 27 02:55:34 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id BEE3F16A4C9; Tue, 27 Jun 2006 02:55:34 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A45116A4A6 for ; Tue, 27 Jun 2006 02:55:34 +0000 (UTC) (envelope-from kip.macy@gmail.com) Received: from nz-out-0102.google.com (nz-out-0102.google.com [64.233.162.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9114A43D6A for ; Tue, 27 Jun 2006 02:55:28 +0000 (GMT) (envelope-from kip.macy@gmail.com) Received: by nz-out-0102.google.com with SMTP id 13so1503300nzp for ; Mon, 26 Jun 2006 19:55:28 -0700 (PDT) DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=hiZeXYuiZ/HY+FiZy6q+TXDmluPqAWXWtYM5ZgGdN7tJ24f8jnDJ1wGTEEafAFRGsvM5NrUGXZE8JBForkO8BX3ihIEacGe8wQQ9PCAGxyTzAkCNwXAEW3cm3vvzZtWHokn3ukssL2OCWStcDHVExOV2K+/JrNALOk0mt2cXbbw= Received: by 10.65.244.14 with SMTP id w14mr2142852qbr; Mon, 26 Jun 2006 19:55:27 -0700 (PDT) Received: by 10.65.225.9 with HTTP; Mon, 26 Jun 2006 19:55:27 -0700 (PDT) Message-ID: Date: Mon, 26 Jun 2006 19:55:27 -0700 From: "Kip Macy" To: "Robert Watson" In-Reply-To: <20060627001336.T79454@fledge.watson.org> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200606262054.k5QKsDq7022302@repoman.freebsd.org> <200606261759.41541.jhb@freebsd.org> <20060627001336.T79454@fledge.watson.org> Cc: Perforce Change Reviews , Kip Macy , John Baldwin Subject: Re: PERFORCE change 100089 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: kmacy@fsmware.com List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Jun 2006 02:55:35 -0000 I've mapped your uipc_usrreq.c into my tree and have seen a measurable boost. I actually see no contention on it. If I go into overload (16 threads) I see the following: 65 13580255 555960120 4332486 3 128 22050892 4323043 /flatstor/shared/p4/sun4v/work_sleepq/src/sys/kern/kern_synch.c:217 (lockbuilder mtxpool) 13 24053476 160697931 92708398 0 1 30726211 0 /flatstor/shared/p4/sun4v/work_sleepq/src/sys/kern/kern_switch.c:522 (runq lock) 371 63389470 27487168 936871 67 29 5918460 640938 /flatstor/shared/p4/sun4v/work_sleepq/src/sys/kern/kern_lock.c:163 (lockbuilder mtxpool) 39 36405448 10970117 4748316 7 2 4132590 0 /flatstor/shared/p4/sun4v/work_sleepq/src/sys/kern/kern_switch.c:221 (runq lock) 361 85861725 10866103 5699832 15 1 3813907 0 /flatstor/shared/p4/sun4v/work_sleepq/src/sys/kern/subr_sleepqueue.c:223 (sleepq chain) lockmgr is my biggest problem now. On 6/26/06, Robert Watson wrote: > On Mon, 26 Jun 2006, John Baldwin wrote: > > > On Monday 26 June 2006 16:54, Kip Macy wrote: > >> http://perforce.freebsd.org/chv.cgi?CH=100089 > >> > >> Change 100089 by kmacy@kmacy_storage:sun4v_work_sleepq on 2006/06/26 > > 20:53:51 > >> > >> add profiling for rwlocks > >> not convinced of correctness as there don't appear to be any contended > > rwlocks on my workloads > > > > Few things use them currently. I have a patch to make the name cache use > > them if you want it. > > You may already have seen this, but I have a UNIX domain socket re-locking in > //depot/user/rwatson/proto/src/sys/kern/uipc_usrreq.c that uses rwlocks and > finer-grained mutexes, among other things. Ideally this can generate some > contention (although perhaps not too much). > > Robert N M Watson > Computer Laboratory > University of Cambridge >