From owner-freebsd-bugs@freebsd.org Wed Aug 15 18:41:30 2018 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 85E8D106BFE6 for ; Wed, 15 Aug 2018 18:41:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id 243C673AA5 for ; Wed, 15 Aug 2018 18:41:30 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id DCE56106BFE3; Wed, 15 Aug 2018 18:41:29 +0000 (UTC) Delivered-To: bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id A2BF6106BFE2 for ; Wed, 15 Aug 2018 18:41:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4559773A9E for ; Wed, 15 Aug 2018 18:41:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 7B223279B9 for ; Wed, 15 Aug 2018 18:41:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w7FIfSpS093718 for ; Wed, 15 Aug 2018 18:41:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w7FIfSJ2093716 for bugs@FreeBSD.org; Wed, 15 Aug 2018 18:41:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: bugs@FreeBSD.org Subject: [Bug 230655] vlan(4) holds non-sleepable locks around driver ioctls Date: Wed, 15 Aug 2018 18:41:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: np@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: bugs@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter cc Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Aug 2018 18:41:30 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230655 Bug ID: 230655 Summary: vlan(4) holds non-sleepable locks around driver ioctls Product: Base System Version: CURRENT Hardware: Any OS: Any Status: New Severity: Affects Many People Priority: --- Component: kern Assignee: bugs@FreeBSD.org Reporter: np@FreeBSD.org CC: mmacy@FreeBSD.org, shurd@FreeBSD.org There was recent work in the stack to not hold non-sleepable locks around NIC driver ioctls. It seems that vlan(4) still does. begin_synchronized_op with the following non-sleepable locks held: exclusive rm vlan (vlan) r =3D 0 (0xfffff8000459e388) locked @ /root/ws/head/sys/net/if_vlan.c:1917 shared rm vlan_rm (vlan_rm) r =3D 0 (0xffffffff827e9480) locked @ /root/ws/head/sys/net/if_vlan.c:1914 stack backtrace: #0 0xffffffff81238331 at witness_debugger+0xf1 #1 0xffffffff812398a8 at witness_warn+0x3b8 #2 0xffffffff8326296c at begin_synchronized_op+0x6c #3 0xffffffff83275b72 at cxgbe_ioctl+0x382 #4 0xffffffff8132e24a at if_addmulti+0x38a #5 0xffffffff8134ebf4 at vlan_setmulti+0x384 #6 0xffffffff8134dbc7 at vlan_ioctl+0x797 #7 0xffffffff8132e24a at if_addmulti+0x38a #8 0xffffffff814181c8 at in_getmulti+0x178 #9 0xffffffff81417ee8 at in_joingroup_locked+0xb8 #10 0xffffffff81417e0a at in_joingroup+0x4a #11 0xffffffff8140f326 at in_aifaddr_ioctl+0xe46 #12 0xffffffff8140d6f8 at in_control+0x228 #13 0xffffffff8132abdd at ifioctl+0x7fd #14 0xffffffff8124e4ce at soo_ioctl+0x79e #15 0xffffffff8124053c at fo_ioctl+0x4c #16 0xffffffff81240291 at kern_ioctl+0x361 #17 0xffffffff8123fe6a at sys_ioctl+0x2ea --=20 You are receiving this mail because: You are the assignee for the bug.=