From owner-cvs-src@FreeBSD.ORG  Thu Feb 12 10:45:10 2004
Return-Path: <owner-cvs-src@FreeBSD.ORG>
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 5B26316A4CE; Thu, 12 Feb 2004 10:45:10 -0800 (PST)
Received: from mailout1.pacific.net.au (mailout1.pacific.net.au [61.8.0.84])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id D3C3C43D1D; Thu, 12 Feb 2004 10:45:09 -0800 (PST)
	(envelope-from bde@zeta.org.au)
Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au
	[61.8.0.87])i1CIj4LE002584;	Fri, 13 Feb 2004 05:45:04 +1100
Received: from gamplex.bde.org (katana.zip.com.au [61.8.7.246])
	i1CIj1EJ017646;	Fri, 13 Feb 2004 05:45:02 +1100
Date: Fri, 13 Feb 2004 05:45:01 +1100 (EST)
From: Bruce Evans <bde@zeta.org.au>
X-X-Sender: bde@gamplex.bde.org
To: juli mallett <jmallett@FreeBSD.org>
In-Reply-To: <20040212075852.GA93983@FreeBSD.org>
Message-ID: <20040213053949.D24403@gamplex.bde.org>
References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org>
 <xzpznbodbo6.fsf@dwp.des.no> <20040212075852.GA93983@FreeBSD.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=X-UNKNOWN
Content-Transfer-Encoding: QUOTED-PRINTABLE
cc: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= <des@des.no>
cc: Tim Kientzle <kientzle@FreeBSD.org>
cc: cvs-all@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: cvs-src@FreeBSD.org
Subject: Re: cvs commit: src/lib/libarchive Makefile
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 12 Feb 2004 18:45:10 -0000

On Thu, 12 Feb 2004, juli mallett wrote:

> * Dag-Erling Sm=F8rgrav <des@des.no> [ Date: 2004-02-12 ]
> =09[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ]
> > Tim Kientzle <kientzle@FreeBSD.org> writes:
> > >   Log:
> > >   libarchive itself is now completely clean at WARNS=3D10 on all arch=
itectures.
> > >
> > >   Unfortunately, the stock zlib.h is not:
> > >     line 885: 'err' parameter shadows global 'err' definition from <e=
rr.h>
> >
> > This is trivial to fix, if we're willing to take zlib.h off the vendor
> > branch or manage to convince Gailly to take our patch.
>
> Personally, I'm against prototype declarations in headers being
> warning checked for parameter names, even moreso for headers not
> included within the headers in question.

We force checking of system (including standard) headers using
-Wsystem-headers, and I think this checking applies here.  I wouldn't
want to turn of checking for all warnings in system headers.

Anyway, names like "err" in system headers are just bugs.  They break
application code like:

#define=09err=09if you can see this, then <zlib.h> is broken
#include <zlib.h>

zlib.h has many such bugs.  It looks like an application header that
escaped to become a system header.

Bruce