Date: Fri, 13 Feb 2004 05:45:01 +1100 (EST) From: Bruce Evans <bde@zeta.org.au> To: juli mallett <jmallett@FreeBSD.org> Cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/lib/libarchive Makefile Message-ID: <20040213053949.D24403@gamplex.bde.org> In-Reply-To: <20040212075852.GA93983@FreeBSD.org> References: <200402120411.i1C4Bf8U036349@repoman.freebsd.org> <xzpznbodbo6.fsf@dwp.des.no> <20040212075852.GA93983@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 12 Feb 2004, juli mallett wrote: > * Dag-Erling Sm=F8rgrav <des@des.no> [ Date: 2004-02-12 ] > =09[ w.r.t. Re: cvs commit: src/lib/libarchive Makefile ] > > Tim Kientzle <kientzle@FreeBSD.org> writes: > > > Log: > > > libarchive itself is now completely clean at WARNS=3D10 on all arch= itectures. > > > > > > Unfortunately, the stock zlib.h is not: > > > line 885: 'err' parameter shadows global 'err' definition from <e= rr.h> > > > > This is trivial to fix, if we're willing to take zlib.h off the vendor > > branch or manage to convince Gailly to take our patch. > > Personally, I'm against prototype declarations in headers being > warning checked for parameter names, even moreso for headers not > included within the headers in question. We force checking of system (including standard) headers using -Wsystem-headers, and I think this checking applies here. I wouldn't want to turn of checking for all warnings in system headers. Anyway, names like "err" in system headers are just bugs. They break application code like: #define=09err=09if you can see this, then <zlib.h> is broken #include <zlib.h> zlib.h has many such bugs. It looks like an application header that escaped to become a system header. Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040213053949.D24403>