From owner-freebsd-current Tue Mar 18 2:51:46 2003 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4562037B401 for ; Tue, 18 Mar 2003 02:51:45 -0800 (PST) Received: from flood.ping.uio.no (flood.ping.uio.no [129.240.78.31]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9494843FA3 for ; Tue, 18 Mar 2003 02:51:44 -0800 (PST) (envelope-from des@ofug.org) Received: by flood.ping.uio.no (Postfix, from userid 2602) id C184C5308; Tue, 18 Mar 2003 11:51:42 +0100 (CET) X-URL: http://www.ofug.org/~des/ X-Disclaimer: The views expressed in this message do not necessarily coincide with those of any organisation or company with which I am or have been affiliated. To: walt Cc: freebsd-current@freebsd.org Subject: Re: Why did INVARIANTS hide the geom bug? From: des@ofug.org (Dag-Erling =?iso-8859-1?q?Sm=F8rgrav?=) Date: Tue, 18 Mar 2003 11:51:42 +0100 In-Reply-To: <3E76018F.5030406@myrealbox.com> (walt's message of "Mon, 17 Mar 2003 09:10:39 -0800") Message-ID: User-Agent: Gnus/5.090015 (Oort Gnus v0.15) Emacs/21.2 References: <3E76018F.5030406@myrealbox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG walt writes: > Looking at the code thru my amateur eyes it appears that > defining INVARIANTS allows the programmer to add whatever > code he wishes with an ifdef statement. That covers a > lot of territory. Looking thru sys/geom I don't see any > such ifdefs in your code, so I still don't know why the > recent geom bug was hidden by INVARIANTS. On the contrary, there is a lot on INVARIANTS-specific code in GEOM: des@dwp /sys/geom% grep -r KASSERT . | wc -l 120 DES -- Dag-Erling Smorgrav - des@ofug.org To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message