From owner-cvs-src@FreeBSD.ORG Thu Feb 28 13:56:50 2008 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 50F7E106566B; Thu, 28 Feb 2008 13:56:50 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from speedfactory.net (mail.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id 71C7E8FC18; Thu, 28 Feb 2008 13:56:49 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8s) with ESMTP id 233689946-1834499 for multiple; Thu, 28 Feb 2008 08:54:42 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.2/8.14.2) with ESMTP id m1SDuYQZ046128; Thu, 28 Feb 2008 08:56:35 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= Date: Thu, 28 Feb 2008 08:01:52 -0500 User-Agent: KMail/1.9.7 References: <200802271902.m1RJ23wd012246@repoman.freebsd.org> <86ejax4bjl.fsf@ds4.des.no> <867igp4b49.fsf@ds4.des.no> In-Reply-To: <867igp4b49.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200802280801.53162.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Thu, 28 Feb 2008 08:56:35 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/6023/Thu Feb 28 07:50:11 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/stdio fdopen.c fopen.c freopen.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 Feb 2008 13:56:50 -0000 On Thursday 28 February 2008 05:40:54 am Dag-Erling Sm=C3=B8rgrav wrote: > Dag-Erling Sm=C3=B8rgrav writes: > > John Baldwin writes: > > > At some point in the future we should look at expanding the file=20 descriptor > > > in FILE to an int, but that is a bit complicated due to ABI issues. > > There shouldn't be any ABI issues, since FILE should never, ever be used > > directly, only through FILE *. >=20 > After reading the discussion on -arch, I take that back; but as Garrett > pointed out, a simple way of fixing it is to just return EMFILE if the > fd we get from open() is >=3D32768. >=20 > It's a pity we're not allowed to increase FOPEN_MAX beyond some > ridiculously low number... The problem is I'd also like it to work if we get a "large" fd. glibc hand= les=20 this fine. =2D-=20 John Baldwin