From owner-svn-ports-head@FreeBSD.ORG Sun Jul 20 21:28:01 2014 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0ABB785B; Sun, 20 Jul 2014 21:28:01 +0000 (UTC) Received: from mail-wi0-x230.google.com (mail-wi0-x230.google.com [IPv6:2a00:1450:400c:c05::230]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id CC4CE2D85; Sun, 20 Jul 2014 21:27:59 +0000 (UTC) Received: by mail-wi0-f176.google.com with SMTP id bs8so3187425wib.9 for ; Sun, 20 Jul 2014 14:27:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=ZOM/Bb1GG35gG24Okxm6Zb4wg81aPf0mUebsOrqki1o=; b=rfMzK6gk5cNokVuJaRFoylRD1P6/sjKCqlBkySMq4bn/ydek3segCgyEfcXXyAjP/J HurZQA3vW72dV6asypavTOf/xr7Eaot/XVfW1mX1mKJTfAXqIM6zqLM/qodsUGsHkbTD 8oHas9iwHjzDjdNRDeT1TXwGeyDaI/V6SmGFbcL1ZZsmlpwiSTsRdfka4eXtyBhP5zf0 CPzX2NW/k9Vuebr4xm4mV+k4P2eii6Ne6rZsVnrH+c1dq4jvtWG5xsgILxZMfx9iw6KU 2GmTXeVPzZmDSYO5pJxHVsaj8bpwyCiooel2IsmXlYcPTHwNuEos1o2XGcPRTIGL38bk oV1g== X-Received: by 10.180.76.68 with SMTP id i4mr52126464wiw.83.1405891677988; Sun, 20 Jul 2014 14:27:57 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id fc7sm32483166wjc.37.2014.07.20.14.27.56 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jul 2014 14:27:57 -0700 (PDT) Sender: Baptiste Daroussin Date: Sun, 20 Jul 2014 23:27:54 +0200 From: Baptiste Daroussin To: Tijl Coosemans Subject: Re: svn commit: r362304 - head/x11-toolkits/pango Message-ID: <20140720212754.GG26778@ivaldir.etoilebsd.net> References: <201407200815.s6K8FG8b003096@svn.freebsd.org> <20140720132259.156d687e@kalimero.tijl.coosemans.org> <53CBA770.2010409@marino.st> <20140720113124.GD26778@ivaldir.etoilebsd.net> <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="PyMzGVE0NRonI6bs" Content-Disposition: inline In-Reply-To: <20140720165256.1f4d5d07@kalimero.tijl.coosemans.org> User-Agent: Mutt/1.5.23 (2014-03-12) Cc: svn-ports-head@freebsd.org, kwm@FreeBSD.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 20 Jul 2014 21:28:01 -0000 --PyMzGVE0NRonI6bs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Jul 20, 2014 at 04:52:56PM +0200, Tijl Coosemans wrote: > On Sun, 20 Jul 2014 13:31:24 +0200 Baptiste Daroussin wrote: > > On Sun, Jul 20, 2014 at 01:26:40PM +0200, John Marino wrote: > >> On 7/20/2014 13:22, Tijl Coosemans wrote: > >>> On Sun, 20 Jul 2014 08:15:16 +0000 (UTC) John Marino wrote: > >>>> Author: marino > >>>> Date: Sun Jul 20 08:15:16 2014 > >>>> New Revision: 362304 > >>>> URL: http://svnweb.freebsd.org/changeset/ports/362304 > >>>> QAT: https://qat.redports.org/buildarchive/r362304/ > >>>> > >>>> Log: > >>>> x11-toolkits/pango: require explicit linking > >>>> =20 > >>>> This new configure argument will list all required libraries in the > >>>> generated pkgconf files. Before any library indirectly pulled in,= such > >>>> as libm, was not listed. > >>>> =20 > >>>> This fixes numerous regression in dports and it's more correct any= way. > >>>=20 > >>> No, this is wrong. Each port should link to the libraries it needs on > >>> its own. No port should rely on other ports to pull in libraries for > >>> them. > >>=20 > >> Then I guess we really don't need pkgconfig .pc files at all then? > >> (This is the point of .pc files, it tells how to link. libm is direct= ly > >> used by pango) > >>=20 > >> so no, it is not wrong. The generated pc file was wrong, now it's not. > >> This is why the configuration argument exists. >=20 > A .pc file normally has 1 library in the Libs field (the library the .pc > file is created for) and 0 items in the Requires field. Dependencies go > in the Libs.private or Requires.private fields. The only reason to add > dependencies to Libs or Requires is if the headers of the library expose > the API of those dependencies (e.g. the library headers define macros or > inline functions that expand to calls to functions in a dependency (such > as Gtk macros that expand to Glib function calls)). >=20 > The pango headers don't even include math.h or complex.h so they cannot > expose its API. The generated .pc file was correct, now it is wrong. >=20 > The reason the configure argument exists is probably because this is an > old .pc file from before the .private fields existed. >=20 > > The good question is "does pango exposes parts of libm or not?" if yes > > then libm should be listed in the libraries of pango.pc is not it should > > only appears in the private field. Libs.private are also there to handle the needed library when something req= uest static linking so having -lm in libs.private could make sense Otherwise I do agrree regards, Bapt --PyMzGVE0NRonI6bs Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iEYEARECAAYFAlPMNFoACgkQ8kTtMUmk6EwOWACfccTFg+axWY5wSKHcB7INSN59 QLUAn1onrLLmwk5iBlSGyQCygLjjicri =/2mT -----END PGP SIGNATURE----- --PyMzGVE0NRonI6bs--