From owner-cvs-ports@FreeBSD.ORG Wed May 2 09:23:17 2012 Return-Path: Delivered-To: cvs-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A7965106566C; Wed, 2 May 2012 09:23:17 +0000 (UTC) (envelope-from utisoft@gmail.com) Received: from mail-bk0-f54.google.com (mail-bk0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 5F28E8FC0C; Wed, 2 May 2012 09:23:16 +0000 (UTC) Received: by bkvi17 with SMTP id i17so376077bkv.13 for ; Wed, 02 May 2012 02:23:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=x/9eAElTAsyXVL8Xi6LZqw/70eBmpjKKb1I8V0sLOx0=; b=IFs+iP+E0voIBWpE9a8vawwgnF6zpUXz/ouAgDTo3c7RbfRcj3Yc1t5IRRO3UPamrY By+/aP5qbm8amL0sIcuO9P+UxK92PTJnSGHX38jgkeDjE38OT9RowL0RNLqkaOCULRcM rRIS6I+HIPdTq7eNOJ2+R8nN4Kskj7LqlbZf6RhqoOSfTVbS2r7mKIcUqSJpMicWgBjU dMnG9Np/w+uSSdYl8L2eOx7rhQQIhqse9cktXGZr7kj57XYj8VS5tobniuh36OEtz12y ndHUHOajyM0b007sDqwCZ+d37whRh4G0zCpHsLL/L0VqpT+UBBM14AuA8YdCvJaUwYQS YDUA== MIME-Version: 1.0 Received: by 10.204.153.15 with SMTP id i15mr4215862bkw.74.1335950594738; Wed, 02 May 2012 02:23:14 -0700 (PDT) Sender: utisoft@gmail.com Received: by 10.204.171.138 with HTTP; Wed, 2 May 2012 02:23:14 -0700 (PDT) Received: by 10.204.171.138 with HTTP; Wed, 2 May 2012 02:23:14 -0700 (PDT) In-Reply-To: <20120502084805.GA83818@megatron.madpilot.net> References: <201204301752.q3UHquWJ034347@repoman.freebsd.org> <20120501204522.GA23385@server.vk2pj.dyndns.org> <20120501234357.792c2599@nemysis3now.no-ip.biz> <20120502084805.GA83818@megatron.madpilot.net> Date: Wed, 2 May 2012 09:23:14 +0000 X-Google-Sender-Auth: K1Vuiuodyo4wLScCa4AX75XjBGw Message-ID: From: Chris Rees To: Guido Falsi Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Cc: Peter Jeremy , cvs-all@freebsd.org, ports-committers@freebsd.org, Thomas Abthorpe , cvs-ports@freebsd.org, nemysis Subject: Re: cvs commit: ports/graphics Makefile ports/graphics/viewnior Makefile distinfo pkg-descr pkg-plist ports/graphics/viewnior/files patch-po_Makefile.in.in X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 May 2012 09:23:17 -0000 On 2 May 2012 09:48, "Guido Falsi" wrote: > > On Tue, May 01, 2012 at 11:43:57PM +0200, nemysis wrote: > > On Wed, 2 May 2012 06:45:22 +1000 > > Peter Jeremy wrote: > > > > > On 2012-Apr-30 17:52:56 +0000, Guido Falsi wrote: > > > > This is Viewnior, an image viewer program. Created to be simple, fast > > > > and elegant. It's minimalistic interface provides more screenspace for > > > > your images. Among its features are: > > > > > > This looks interesting, thanks. > > > > > > I notice that NLS is a configure-time option but USE_GETTEXT is > > > unconditionally set (as well as being set within the !WITHOUT_NLS > > > condtiional block). I presume this is a cut-and-paste error. > > > > > > > > > I have seen that in FreeBSD Ports collection is older version as you have > > give me and i have adjusted. > > > > diff -ruN viewnior.old viewnior > viewnior.diff > > > > Should I this send to freebsd-ports-bugs@freebsd.org > > I see that the problem is caused by USE_GETTEXT being defined both > unconditionally and in the option check. Sorry, this is my fault. > > If you approve I'd commit the attached simple fix. > Please go for it- sorry I missed it too. Chris