From owner-freebsd-current@FreeBSD.ORG Tue Dec 23 16:34:14 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 17D74106564A; Tue, 23 Dec 2008 16:34:14 +0000 (UTC) (envelope-from hselasky@c2i.net) Received: from swip.net (mailfe15.swip.net [212.247.155.193]) by mx1.freebsd.org (Postfix) with ESMTP id 242608FC12; Tue, 23 Dec 2008 16:34:11 +0000 (UTC) (envelope-from hselasky@c2i.net) X-Cloudmark-Score: 0.000000 [] X-Cloudmark-Analysis: v=1.0 c=1 a=pgw_eo6bRDYA:10 a=JgwOP_QsqSoA:10 a=_WP56rCiPeEfZst03u0A:9 a=2SELt1wdaOFp270u5pqpTQ44yT8A:4 a=SV7veod9ZcQA:10 a=50e4U0PicR4A:10 Received: from [193.217.167.134] (account mc467741@c2i.net HELO [10.0.0.186]) by mailfe15.swip.net (CommuniGate Pro SMTP 5.2.6) with ESMTPA id 425147755; Tue, 23 Dec 2008 17:34:10 +0100 From: Hans Petter Selasky To: freebsd-current@freebsd.org Date: Tue, 23 Dec 2008 17:36:28 +0100 User-Agent: KMail/1.9.7 References: <20081222214010.GA18389@elvis.mu.org> <20081223151942.GP18389@elvis.mu.org> <86y6y6ubxc.fsf@ds4.des.no> In-Reply-To: <86y6y6ubxc.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Message-Id: <200812231736.29198.hselasky@c2i.net> Cc: Dag-Erling =?utf-8?q?Sm=C3=B8rgrav?= , Alfred Perlstein , current@freebsd.org Subject: Re: HEADSUP usb2 (usb4bsd) to become default in 2 weeks. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Dec 2008 16:34:14 -0000 Hi, On Tuesday 23 December 2008, Dag-Erling Sm=C3=B8rgrav wrote: > Alfred Perlstein writes: > > Dag-Erling Sm=C3=B8rgrav writes: > > > You know very well that there are, and you also know very well that > > > this is too big a change to go in without discussion. > > > > Perhaps you can list them for me [...] > > There are serious issues with the permissions model, which were raised > in Strasbourg and AFAIK never addressed. This is more complicated than you think. If you require a change in this ar= ea=20 than please point me to an existing example implementing something similar.= I=20 know about the "kern_priv()" function, but there are no specific groups for= =20 USB, which needs to be discussed. The current implementation is good enough= =20 for most use cases in my opinion. > There are complaints from other developers (Warner, for one) that their > reviews were ignored. > > > 3) I think you were mad about whitespace or something, but like this > > case, you were not up for bringing specifics to the table. > It is limited what one person can do. > That's untrue - I dropped the issue because I thought thompsa@ was > working on it, but he didn't touch the userland parts. I have a > 3,000-line diff for libusb20 which no longer applies due to intervening > changes. Looking at the updated code, I'm still concerned about the > widespread use of obufscated pointer arithmetic - the LIBUSB20_ADD_BYTES > macro, for instance, is even worse now than when I last looked at > libusb20. If you have a better way to do things then please show me. If you think it= =20 still applies then please sent it to me. LIBUSB20_ADD_BYTES() is a hack to circumvent things like un-constifying and= =20 making a byte increment to any pointer type. USB descriptors are byte-packe= d.=20 I have tested the macro with several kinds of compilers and none have=20 complained yet. =2D-HPS