From owner-cvs-usrbin  Wed Feb 26 20:36:16 1997
Return-Path: <owner-cvs-usrbin>
Received: (from root@localhost)
          by freefall.freebsd.org (8.8.5/8.8.5) id UAA02344
          for cvs-usrbin-outgoing; Wed, 26 Feb 1997 20:36:16 -0800 (PST)
Received: from labs.usn.blaze.net.au (labs.usn.blaze.net.au [203.17.53.30])
          by freefall.freebsd.org (8.8.5/8.8.5) with ESMTP id UAA02149;
          Wed, 26 Feb 1997 20:33:53 -0800 (PST)
Received: (from davidn@localhost)
	by labs.usn.blaze.net.au (8.8.5/8.8.5) id PAA10699;
	Thu, 27 Feb 1997 15:33:32 +1100 (EST)
Message-ID: <19970227153331.46240@usn.blaze.net.au>
Date: Thu, 27 Feb 1997 15:33:31 +1100
From: David Nugent <davidn@labs.usn.blaze.net.au>
To: "Andrey A. Chernov" <ache@freefall.freebsd.org>
Cc: CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org,
        cvs-usrbin@freefall.freebsd.org
Subject: Re: cvs commit:  src/usr.bin/login login.c
References: <199702270352.TAA00359@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.61
In-Reply-To: <199702270352.TAA00359@freefall.freebsd.org>; from Andrey A. Chernov on Feb 02, 1997 at 07:52:23PM
Sender: owner-cvs-usrbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Feb 02, 1997 at 07:52:23PM, Andrey A. Chernov wrote:
>   Modified:    usr.bin/login  login.c
>   Log:
>   Fix few bogons with pw_shell / shell variables values mismatch
>   introduced by LOGIN_CAP

This breaks the shell= function.

"shell=" in /etc/login.conf should NOT be set in the $SHELL
environment variable. This is BSDI's usage, and it should
also be ours - in fact, according to our documentation it is:

Extract from login.conf(5):

 shell       prog           Session shell to execute rather than the
                            shell specified in the passwd file. The
                            SHELL environment variable will contain
                            the shell specified in the password file.

The point of having this facility is to allow the sysadmin to
run a program or script which may optionally execute the
user's shell or other programs via system(). Many people over
the years have had to hack login(1) to do this instead (menus,
service selectors etc), and this facility makes it unnecessary
to actually hack system code to achieve the desired result.

In other words, "shell=" is not intended to replace the shell
field in the password file, but to compliment it.

I agree that the tag is poorly named. It probably should be
"preshell=", "run=" or just about anything other than "shell=".


Regards,

David Nugent - Unique Computing Pty Ltd - Melbourne, Australia
Voice +61-3-9791-9547  Data/BBS +61-3-9792-3507  3:632/348@fidonet
davidn@freebsd.org davidn@blaze.net.au http://www.blaze.net.au/~davidn/