From owner-freebsd-testing@FreeBSD.ORG Wed Mar 19 23:29:54 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4EBB3A51 for ; Wed, 19 Mar 2014 23:29:54 +0000 (UTC) Received: from mail-qc0-f179.google.com (mail-qc0-f179.google.com [209.85.216.179]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 0CF5AD21 for ; Wed, 19 Mar 2014 23:29:53 +0000 (UTC) Received: by mail-qc0-f179.google.com with SMTP id m20so64682qcx.24 for ; Wed, 19 Mar 2014 16:29:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=oEhoL1EzLE66LyPSKdtWeu2ioqCfR5Go6GOMIiiowL4=; b=MgHxDpPKJJFxMIBPNGeK44gML+0kB0N4EuPFDd+4Ax4t+8VR6byeyRy7yrmeBq50Iz BiGfbYuwoJ47AlqSvCw2fObo6e91gQ9CWjtSbDhjLXNd5NHB70eWxi30FMg6Vl0xSxOH rXGnJGIUNAhjJdbpTya2YzKosSFYhesG0tMya3xUMagvYPVRXGyl9ZlhetnZV3dFbKHp 97zjpmwV+uy1ORbx0dyuQ+pSl4KD8N6VfkeeRPUST8X67YRHXNutTL/eMVdeP9ffNVpC u1iLzhRc1JR59ZDaDy2q4qELyrPGOTkMpwTYbB0smU21IJ2pi2QrNOUqjXNeysUvqOdm 1d9Q== X-Gm-Message-State: ALoCoQm+QRo5hDMSyhonmv0sMji1pCYVIVxLXhh/lgHA2qZVl7dnCTNmqBo49evZkp3vb+NOC7gO X-Received: by 10.140.40.5 with SMTP id w5mr43697015qgw.65.1395271787650; Wed, 19 Mar 2014 16:29:47 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.102 with HTTP; Wed, 19 Mar 2014 16:29:27 -0700 (PDT) X-Originating-IP: [1.242.225.82] In-Reply-To: References: <16437CC5729B5345AF77F816513376E812981CA4@MX103CL02.corp.emc.com> From: Julio Merino Date: Thu, 20 Mar 2014 08:29:27 +0900 X-Google-Sender-Auth: TQoMvQaYO_KOJGlu_XKGm3hFnEU Message-ID: Subject: Re: kyua requirement testing for tap tests To: Alan Somers Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Mar 2014 23:29:54 -0000 On Thu, Mar 20, 2014 at 8:05 AM, Alan Somers wrote: > On Wed, Mar 19, 2014 at 3:47 PM, Peel, Casey wrot= e: >> The src/usr.sbin/sed/tests/multi_test.sh test requires the /usr/share/di= ct/words file but it doesn't explicitly state this. We don't ship that file= and thus the test fails. What is the correct way to specify requirements f= or tap tests such that kyua skips this test if it doesn't exist? The only o= ption I've come up with thus far is commenting out the multi_test suite alt= ogether from the Makefile. > > You need to set the required_files metadata variable for the test > program. I don't think that the TAP API has a way to do that, but can > you do it in the Kyuafile like this? > > tap_test_program(name=3D"multi_test", required_files=3D"/usr/share/dict/w= ords") Yes you can. (Note that those parenthesis ought to be braces though.) And you could do: TEST_METADATA.multi_test+=3D required_files=3D"/usr/share/dict/words" in the Makefile to avoid having to write a Kyuafile by hand. Fixed in r263388; thanks!