From owner-freebsd-ports-bugs@FreeBSD.ORG Mon Oct 29 19:40:04 2007 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4524A16A420 for ; Mon, 29 Oct 2007 19:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 1C83E13C4AA for ; Mon, 29 Oct 2007 19:40:04 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.1/8.14.1) with ESMTP id l9TJe3Oh018585 for ; Mon, 29 Oct 2007 19:40:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.1/8.14.1/Submit) id l9TJe3Ou018583; Mon, 29 Oct 2007 19:40:03 GMT (envelope-from gnats) Date: Mon, 29 Oct 2007 19:40:03 GMT Message-Id: <200710291940.l9TJe3Ou018583@freefall.freebsd.org> To: freebsd-ports-bugs@FreeBSD.org From: Sunpoet Po-Chuan Hsieh Cc: Subject: Re: ports/117635: [graphics/ImageMagick] add missing file in pkg-plist (fix make deinstall) X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Sunpoet Po-Chuan Hsieh List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Oct 2007 19:40:04 -0000 The following reply was made to PR ports/117635; it has been noted by GNATS. From: Sunpoet Po-Chuan Hsieh To: bug-followup@FreeBSD.org Cc: Subject: Re: ports/117635: [graphics/ImageMagick] add missing file in pkg-plist (fix make deinstall) Date: Tue, 30 Oct 2007 03:20:30 +0800 I apologize for giving out a wrong patch. The truth is ImageMagick installs exr.* regardless of IMAGEMAGICK_OPENEXR option. Since IMAGEMAGICK_OPENEXR is default off, we should use defined(WITH_...) instead of !defined(WITHOUT_...). The correct patch file should be: --- /usr/ports/graphics/ImageMagick/Makefile.orig 2007-10-29 16:33:56.000000000 +0800 +++ /usr/ports/graphics/ImageMagick/Makefile 2007-10-30 03:14:11.000000000 +0800 @@ -132,12 +132,10 @@ PLIST_SUB+= MODULES='@comment ' .endif -.if !defined(WITHOUT_IMAGEMAGICK_OPENEXR) +.if defined(WITH_IMAGEMAGICK_OPENEXR) LIB_DEPENDS+= IlmImf:${PORTSDIR}/graphics/OpenEXR -PLIST_SUB+= OPENEXR="" .else CONFIGURE_ARGS+= --without-openexr -PLIST_SUB+= OPENEXR="@comment " .endif .if !defined(WITHOUT_IMAGEMAGICK_DJVU) --- /usr/ports/graphics/ImageMagick/pkg-plist.orig 2007-10-05 13:32:09.000000000 +0800 +++ /usr/ports/graphics/ImageMagick/pkg-plist 2007-10-30 02:41:05.000000000 +0800 @@ -187,6 +187,9 @@ %%TIFF%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/ept.a %%TIFF%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/ept.la %%TIFF%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/ept.so +%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.a +%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.la +%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.so %%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/fax.a %%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/fax.la %%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/fax.so @@ -310,9 +313,6 @@ %%PNG%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/png.a %%PNG%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/png.la %%PNG%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/png.so -%%OPENEXR%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.a -%%OPENEXR%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.la -%%OPENEXR%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/exr.so %%DJVU%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/djvu.a %%DJVU%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/djvu.la %%DJVU%%%%MODULES%%lib/ImageMagick/modules-%%QBIT%%/coders/djvu.so