From owner-freebsd-current@FreeBSD.ORG Thu Nov 22 15:12:42 2012 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6475332F; Thu, 22 Nov 2012 15:12:42 +0000 (UTC) (envelope-from edschouten@gmail.com) Received: from mail-ob0-f182.google.com (mail-ob0-f182.google.com [209.85.214.182]) by mx1.freebsd.org (Postfix) with ESMTP id 17AE18FC13; Thu, 22 Nov 2012 15:12:41 +0000 (UTC) Received: by mail-ob0-f182.google.com with SMTP id 16so10509254obc.13 for ; Thu, 22 Nov 2012 07:12:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=CDizNjdgjBjkNZapz5821y3LyDj/Te7yBDPGtSayxG0=; b=tHHMtNuEkqN+GR/ze3sYLBebnMU0yYm1nbHheZOb6ieQdoitwJ7FV163z6ayyMFF9M Qxd15BH5ABAk+wvs64sE4l1d/yxoKtYYCBQA09ttTTwEIH0Z6vTpCGApXpshn5QtzBd0 jZalSTen9Heo8HOL2XJM19jzh0dcCznPqsaGLYjv10j3UkQVcKTRK4SNy0VvDLmyvi5T flBc6kD3o6jYNnVKPQM7v+/ed8uaLHpuVkkh1peeL1G932LuGAtW5CRVJ3NtcVcDre6l 4Da0Ovkaf8MSTCzItz2VMpqhQduUl//FEJmvcSqTb0yudW7N8dHnk9z5APmF+JnAZadp MNOg== MIME-Version: 1.0 Received: by 10.182.95.205 with SMTP id dm13mr674675obb.9.1353597161387; Thu, 22 Nov 2012 07:12:41 -0800 (PST) Sender: edschouten@gmail.com Received: by 10.76.151.39 with HTTP; Thu, 22 Nov 2012 07:12:41 -0800 (PST) In-Reply-To: <50ADF2D4.2010805@freebsd.org> References: <50ADF2D4.2010805@freebsd.org> Date: Thu, 22 Nov 2012 16:12:41 +0100 X-Google-Sender-Auth: h-M4DXa9wSv3679o2URyocD-lX4 Message-ID: Subject: Re: Is this a typo in if_tap.c? From: Ed Schouten To: David Xu Content-Type: text/plain; charset=UTF-8 Cc: freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Nov 2012 15:12:42 -0000 2012/11/22 David Xu : > When I was trying to create a second tap device, kernel crashed. > Is this patch correct ? Yes, it looks okay. Eventually we should get rid of the entire unit numbering thing in if_tap and if_tun. If we would, we could remove a lot of dead code from sys/sys/conf.h and sys/kern/kern_conf.c. -- Ed Schouten