Date: Mon, 06 Jun 2022 08:22:53 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: =?UTF-8?B?W0J1ZyAyNjQ0NzVdIFtORVcgUE9SVF0gc2VjdXJpdHkvb3BlbmNh?= =?UTF-8?B?LW9jc3BkIDogT3BlbkNB4oCZcyBPQ1NQIHJlc3BvbmRlcg==?= Message-ID: <bug-264475-7788-bB3klZdUC1@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-264475-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-264475-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D264475 Daniel Engberg <diizzy@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |diizzy@FreeBSD.org --- Comment #1 from Daniel Engberg <diizzy@FreeBSD.org> --- Hi, Thanks for your patch! Looks good overall but there are some parts that loo= ks a bit strange (quick review) security/openca-ocspd/Makefile L6: DISTVERSIONPREFIX should be defined before DISTVERSION Ref: "Example 17. Use of USE_GITHUB with DISTVERSIONPREFIX" in Porters Hand= book L13: Please also define LICENSE_FILE L21: Remove L31: Shouldn't be needed, if so please fix patches openca-ocspd/files/patch-global-vars.in - Is this patch correct? security/openca-ocspd/pkg-plist L2, L3: This is a bit hacky, just remove the files in ports Makefile and/or project Makefile(s) Tested on (version, arch)? Does it build using Poudriere? Please also try to submit changes to upstream Best regards, Daniel --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-264475-7788-bB3klZdUC1>