From owner-dev-commits-src-main@freebsd.org Wed Apr 28 01:30:34 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id E7B6A627F13; Wed, 28 Apr 2021 01:30:34 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4FVLfy6Bl8z3MWh; Wed, 28 Apr 2021 01:30:34 +0000 (UTC) (envelope-from rpokala@freebsd.org) Received: from [192.168.1.10] (unknown [98.42.164.217]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) (Authenticated sender: rpokala) by smtp.freebsd.org (Postfix) with ESMTPSA id 2A75931882; Wed, 28 Apr 2021 01:30:34 +0000 (UTC) (envelope-from rpokala@freebsd.org) User-Agent: Microsoft-MacOutlook/16.48.21041102 Date: Tue, 27 Apr 2021 18:30:30 -0700 Subject: Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9) From: Ravi Pokala To: Baptiste Daroussin , Ravi Pokala CC: , , Message-ID: Thread-Topic: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9) References: <202104270309.13R39Lur024105@gitrepo.freebsd.org> <705D11CB-3762-4437-8825-8E3040BBAB9F@panasas.com> <20210427070557.wv3lkor3tscxzdtg@aniel.nours.eu> In-Reply-To: <20210427070557.wv3lkor3tscxzdtg@aniel.nours.eu> Mime-version: 1.0 Content-type: text/plain; charset="UTF-8" Content-transfer-encoding: 7bit X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Apr 2021 01:30:35 -0000 -----Original Message----- From: Baptiste Daroussin Date: 2021-04-27, Tuesday at 00:05 To: Ravi Pokala Cc: , , Subject: Re: 0cd4b781a6fa - main - pw(8): use openmemstream instead of sbuf(9) On Mon, Apr 26, 2021 at 09:13:53PM -0700, Ravi Pokala wrote: > -----Original Message----- ... > Hi Baptiste, > > pw(8): use openmemstream instead of sbuf(9) > > That's the "what", but what's the "why"? > > Thanks, > You are right about this. Here the why. I have been the one introducing sbug in pw(8) when I rewrote it, but since the beginning while I found this was better than the solution in place I didn't like adding another external lib just for that. Fair enough. Short after I discovered about open_memstream(3) and figured it could fill the same spot here but keeping the dep only on libc. I keep forgetting that open_memstream(3) is even a thing. `grep'ing the src tree, it looks like it's very rarely used. I was puzzled about pushing this change, and the switch to git reminded me about some uncommit patches sitting on my tree and I ended up pushing it. If people have strong opinion I can revert it back. I can't imagine anyone having a problem with this. :-) Thanks for explaining. -Ravi (rpokala@) Things that have not been taken in account in the change, but to answer questions asked privately: - I have performed absolutely no performance benchmark, it does not matter here. - The size of the final binary is smaller: - 76k on amd64 for the new version - 77k for the old version Best regards, Bapt