From owner-svn-src-head@FreeBSD.ORG Tue May 19 14:03:04 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 11C6C93D; Tue, 19 May 2015 14:03:04 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DDACF1FA4; Tue, 19 May 2015 14:03:03 +0000 (UTC) Received: from ralph.baldwin.cx (pool-173-54-116-245.nwrknj.fios.verizon.net [173.54.116.245]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id 2FC37B93C; Tue, 19 May 2015 10:03:02 -0400 (EDT) From: John Baldwin To: Bruce Evans Cc: Julian Elischer , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r283105 - head/share/man/man9 Date: Tue, 19 May 2015 09:52:15 -0400 Message-ID: <3610610.hSkXANVPkf@ralph.baldwin.cx> User-Agent: KMail/4.14.3 (FreeBSD/10.1-STABLE; KDE/4.14.3; amd64; ; ) In-Reply-To: <20150519214041.J3472@besplex.bde.org> References: <201505191133.t4JBX54w093912@svn.freebsd.org> <20150519214041.J3472@besplex.bde.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 19 May 2015 10:03:02 -0400 (EDT) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 May 2015 14:03:04 -0000 On Tuesday, May 19, 2015 10:34:11 PM Bruce Evans wrote: > It would be better to fix the function to match its documented name. > > Many other function names are similarly broken. For example, the primary > function in getenv(9). I agree. :( I would prefer to restore the psignal() and getenv() names. getenv() also has the related misfeature that only getenv() was renamed, but not functions like getenv_int() (similar to pgsignal() for psignal()). Given that no attempt was made to handle the far more pervasive issues with printf and malloc, I think these renames should be reverted. If someone wants to have a user-mode kernel then whatever solution is devised for malloc() (whether #define or symbol renaming trickery) can be done for getenv() and psignal(). -- John Baldwin